From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759647AbWLCNFb (ORCPT ); Sun, 3 Dec 2006 08:05:31 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759649AbWLCNFb (ORCPT ); Sun, 3 Dec 2006 08:05:31 -0500 Received: from srv5.dvmed.net ([207.36.208.214]:20941 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1759647AbWLCNFa (ORCPT ); Sun, 3 Dec 2006 08:05:30 -0500 Message-ID: <4572CB98.6050700@garzik.org> Date: Sun, 03 Dec 2006 08:05:28 -0500 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Mikael Pettersson CC: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2.6.19 1/3] sata_promise: PHYMODE4 fixup References: <200612010955.kB19twqh002446@alkaid.it.uu.se> In-Reply-To: <200612010955.kB19twqh002446@alkaid.it.uu.se> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.3 (----) X-Spam-Report: SpamAssassin version 3.1.7 on srv5.dvmed.net summary: Content analysis details: (-4.3 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Mikael Pettersson wrote: > This patch adds code to fix up the PHYMODE4 "align timing" > register value on second-generation Promise SATA chips. > Failure to correct this value on non-x86 machines makes > drive detection prone to failure due to timeouts. (I've > observed about 50% detection failure rates on SPARC64.) > > The HW boots with a bad value in this register, but on x86 > machines the Promise BIOS corrects it to the value recommended > by the manual, so most people have been unaffected by this issue. > > After developing the patch I checked Promise's SATAII driver, > and discovered that it also corrects PHYMODE4 just like this > patch does. > > This patch depends on the sata_promise SATAII updates > patch I sent recently. > > Signed-off-by: Mikael Pettersson applied