From: Tejun Heo <htejun@gmail.com>
To: Mikael Pettersson <mikpe@it.uu.se>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.19 3/3] sata_promise: cleanups
Date: Sun, 03 Dec 2006 22:05:51 +0900 [thread overview]
Message-ID: <4572CBAF.1010800@gmail.com> (raw)
In-Reply-To: <200612010959.kB19xmAw002464@alkaid.it.uu.se>
Mikael Pettersson wrote:
> This patch performs two simple cleanups of sata_promise.
>
> * Remove board_20771 and map device id 0x3577 to board_2057x.
> After the recent corrections for SATAII chips, board_20771 and
> board_2057x were equivalent in the driver.
Ack.
> * Remove hp->hotplug_offset and use hp->flags & PDC_FLAG_GEN_II
> to compute hotplug_offset in pdc_host_init().
Please explain why.
> @@ -704,7 +684,7 @@ static void pdc_host_init(unsigned int c
> {
> void __iomem *mmio = pe->mmio_base;
> struct pdc_host_priv *hp = pe->private_data;
> - int hotplug_offset = hp->hotplug_offset;
> + int hotplug_offset = (hp->flags & PDC_FLAG_GEN_II) ? PDC2_SATA_PLUG_CSR : PDC_SATA_PLUG_CSR;
People tend to prefer explicit if () over ?: and dislike lines much
longer than 80 column, well, at least in libata.
Thanks.
--
tejun
next prev parent reply other threads:[~2006-12-03 13:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-01 9:59 [PATCH 2.6.19 3/3] sata_promise: cleanups Mikael Pettersson
2006-12-03 13:05 ` Tejun Heo [this message]
2006-12-03 13:07 ` Jeff Garzik
-- strict thread matches above, loose matches on Subject: below --
2006-12-06 8:51 Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4572CBAF.1010800@gmail.com \
--to=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@it.uu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox