From: Zach Brown <zach.brown@oracle.com>
To: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [patch] remove redundant iov segment check
Date: Mon, 04 Dec 2006 11:50:14 -0800 [thread overview]
Message-ID: <45747BF6.9090502@oracle.com> (raw)
In-Reply-To: <000401c717dc$bff0c5e0$2589030a@amr.corp.intel.com>
> Maybe we should create another internal generic_file_aio_read/write
> for in-core function? fs/read_write.c and fs/aio.c are not module-able
> and the check is already there. For external module, we can do the
> check and then calls down to the internal one.
Maybe. I'd rather see fewer moving parts here, not more.
> I hate to see iov is being walked multiple times ....
Indeed, hence the desire to walk it once and pass down a summary of the
results in an explicit struct. The patch in this thread removes one
redundancy, but there are many. I think I counted 6 iovec walks in some
path? I can't remember which. I'd rather tackle them all in one go.
- z
next prev parent reply other threads:[~2006-12-04 19:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 16:26 [patch] remove redundant iov segment check Chen, Kenneth W
2006-12-04 19:18 ` Zach Brown
2006-12-04 19:45 ` Chen, Kenneth W
2006-12-04 19:50 ` Zach Brown [this message]
2007-01-02 11:01 ` Christoph Hellwig
2007-01-02 18:22 ` Zach Brown
2007-01-02 18:25 ` Chen, Kenneth W
2006-12-04 19:36 ` Andrew Morton
2006-12-04 19:50 ` Chen, Kenneth W
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45747BF6.9090502@oracle.com \
--to=zach.brown@oracle.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=kenneth.w.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox