From: Jeff Garzik <jeff@garzik.org>
To: Martin Bligh <mbligh@google.com>
Cc: Andrew Morton <akpm@osdl.org>,
James Bottomley <James.Bottomley@SteelEye.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Fix up compiler warnings in megaraid driver
Date: Mon, 04 Dec 2006 23:58:09 -0500 [thread overview]
Message-ID: <4574FC61.30804@garzik.org> (raw)
In-Reply-To: <4574D8EB.1060104@google.com>
Martin Bligh wrote:
> Fix up compiler warnings in megaraid driver
>
> Signed-off-by: Martin J. Bligh <mbligh@google.com>
>
>
> ------------------------------------------------------------------------
>
> diff -aurpN -X /home/mbligh/.diff.exclude linux-2.6.19/drivers/scsi/megaraid.c 2.6.19-megaraid/drivers/scsi/megaraid.c
> --- linux-2.6.19/drivers/scsi/megaraid.c 2006-12-04 17:52:00.000000000 -0800
> +++ 2.6.19-megaraid/drivers/scsi/megaraid.c 2006-12-04 18:24:03.000000000 -0800
> @@ -73,10 +73,14 @@ static unsigned short int max_mbox_busy_
> module_param(max_mbox_busy_wait, ushort, 0);
> MODULE_PARM_DESC(max_mbox_busy_wait, "Maximum wait for mailbox in microseconds if busy (default=MBOX_BUSY_WAIT=10)");
>
> -#define RDINDOOR(adapter) readl((adapter)->base + 0x20)
> -#define RDOUTDOOR(adapter) readl((adapter)->base + 0x2C)
> -#define WRINDOOR(adapter,value) writel(value, (adapter)->base + 0x20)
> -#define WROUTDOOR(adapter,value) writel(value, (adapter)->base + 0x2C)
> +#define RDINDOOR(adapter) readl((volatile void __iomem *) \
> + (adapter)->base + 0x20)
> +#define RDOUTDOOR(adapter) readl((volatile void __iomem *) \
> + (adapter)->base + 0x2C)
> +#define WRINDOOR(adapter,value) writel(value, (volatile void __iomem *)\
> + (adapter)->base + 0x20)
> +#define WROUTDOOR(adapter,value) writel(value, (volatile void __iomem *)\
> + (adapter)->base + 0x2C)
>
> /*
> * Global variables
I posted a better fix just yesterday...
Jeff
prev parent reply other threads:[~2006-12-05 4:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-05 2:26 [PATCH] Fix up compiler warnings in megaraid driver Martin Bligh
2006-12-05 4:58 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4574FC61.30804@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox