From: Tejun Heo <htejun@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
linux-kernel@vger.kernel.org, akpm@osdl.org,
Jeff Garzik <jgarzik@pobox.com>
Subject: Re: [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2
Date: Wed, 06 Dec 2006 09:15:03 +0900 [thread overview]
Message-ID: <45760B87.5050402@gmail.com> (raw)
In-Reply-To: <20061205235701.74b4c07b@localhost.localdomain>
Alan wrote:
> On Wed, 6 Dec 2006 00:23:03 +0100
> "Bartlomiej Zolnierkiewicz" <bzolnier@gmail.com> wrote:
>
>> Looks good but aren't this trying to fix the same ICH
>> issue that is fixed in libata by ap->ops->irq_clear(ap)?
>>
>> [ please see Tejun's mail: http://lkml.org/lkml/2006/11/15/94 ]
>>
>> If so shouldn't we apply this fix for all ICH5/6/7/8 chipsets?
>
> Possibly. Thats one reason I made it a quirk bit. I'd certainly expect it
> to be a group of related chipsets.
>
>> Also shouldn't the fix be in IRQ handler? Currently the fix is limited
>> to ide-cd driver which seems to be the wrong place as the problem
>> is supposed to happen also when using other IDE device drivers
>> or/and other ATA/ATAPI devices?
>
> The problem has only be observed with CD devices doing PIO ATAPI
> commands. I am not aware of an Intel errata document that characterises
> this errata so anything else so cannot guess further. Perhaps Intel can
> advise ?
FWIW, on my ICH7, the IRQ storm does occur on ATA devices.
--
tejun
prev parent reply other threads:[~2006-12-06 0:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 16:30 [PATCH] ide-cd: Handle strange interrupt on the Intel ESB2 Alan
2006-12-05 23:23 ` Bartlomiej Zolnierkiewicz
2006-12-05 23:57 ` Alan
2006-12-06 0:15 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45760B87.5050402@gmail.com \
--to=htejun@gmail.com \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox