From: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
To: Greg KH <gregkh@suse.de>, tom.l.nguyen@intel.com
Cc: linux-pci@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: [BUG][PATCH] pcieport-driver: remove invalid warning message
Date: Wed, 06 Dec 2006 22:07:30 +0900 [thread overview]
Message-ID: <4576C092.5030202@jp.fujitsu.com> (raw)
Hi,
I got the following warning messages on some PCI Express ports.
pcie_portdrv_probe->Dev[1263:10cf] has invalid IRQ. Check vendor BIOS
I think this message is improper because those PCI Express ports don't
use an interrupt pin. This message should not be displayed for devices
which don't use an interrupt pin.
Thanks,
Kenji Kaneshige
The following warning message should not be displayed for devices
which don't use an interrupt pin.
pcie_portdrv_probe->Dev[XXXX:XXXX] has invalid IRQ. Check vendor BIOS
Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
---
drivers/pci/pcie/portdrv_pci.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.19/drivers/pci/pcie/portdrv_pci.c
===================================================================
--- linux-2.6.19.orig/drivers/pci/pcie/portdrv_pci.c 2006-12-06 21:31:32.000000000 +0900
+++ linux-2.6.19/drivers/pci/pcie/portdrv_pci.c 2006-12-06 21:31:38.000000000 +0900
@@ -90,7 +90,7 @@
return -ENODEV;
pci_set_master(dev);
- if (!dev->irq) {
+ if (!dev->irq && dev->pin) {
printk(KERN_WARNING
"%s->Dev[%04x:%04x] has invalid IRQ. Check vendor BIOS\n",
__FUNCTION__, dev->device, dev->vendor);
reply other threads:[~2006-12-06 13:13 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4576C092.5030202@jp.fujitsu.com \
--to=kaneshige.kenji@jp.fujitsu.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox