From: Michael Krufky <mkrufky@linuxtv.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: mchehab@infradead.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org
Subject: Re: [v4l-dvb-maintainer] [2.6 patch] cx88/saa7134: remove unused -DHAVE_VIDEO_BUF_DVB
Date: Thu, 07 Dec 2006 10:36:01 -0500 [thread overview]
Message-ID: <457834E1.1090406@linuxtv.org> (raw)
In-Reply-To: <20061207150028.GJ8963@stusta.de>
Adrian Bunk wrote:
> This patch removes the unused HAVE_VIDEO_BUF_DVB define.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.19-rc6-mm2/drivers/media/video/cx88/Makefile.old 2006-12-07 15:04:11.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/drivers/media/video/cx88/Makefile 2006-12-07 15:05:04.000000000 +0100
> @@ -13,7 +13,6 @@
> EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
>
> -extra-cflags-$(CONFIG_VIDEO_BUF_DVB) += -DHAVE_VIDEO_BUF_DVB=1
> extra-cflags-$(CONFIG_VIDEO_CX88_VP3054)+= -DHAVE_VP3054_I2C=1
>
> EXTRA_CFLAGS += $(extra-cflags-y) $(extra-cflags-m)
> --- linux-2.6.19-rc6-mm2/drivers/media/video/saa7134/Makefile.old 2006-12-07 15:04:45.000000000 +0100
> +++ linux-2.6.19-rc6-mm2/drivers/media/video/saa7134/Makefile 2006-12-07 15:04:58.000000000 +0100
> @@ -15,6 +15,3 @@
> EXTRA_CFLAGS += -Idrivers/media/dvb/dvb-core
> EXTRA_CFLAGS += -Idrivers/media/dvb/frontends
>
> -extra-cflags-$(CONFIG_VIDEO_BUF_DVB) += -DHAVE_VIDEO_BUF_DVB=1
> -
> -EXTRA_CFLAGS += $(extra-cflags-y) $(extra-cflags-m)
NACK.
HAVE_VIDEO_BUF_DVB is not "unused" ... This symbol is tested for in the
following locations:
cx88.h:34:#ifdef HAVE_VIDEO_BUF_DVB
cx88.h:327:#ifdef HAVE_VIDEO_BUF_DVB
cx88.h:503:#ifdef HAVE_VIDEO_BUF_DVB
cx88-i2c.c:157:#ifdef HAVE_VIDEO_BUF_DVB
saa7134.h:51:#ifdef HAVE_VIDEO_BUF_DVB
saa7134.h:569:#ifdef HAVE_VIDEO_BUF_DVB
...We need this in order to allow compilation of the cx88 / saa7134 modules
without DVB support. (analog only)
If you want to convert the HAVE_VIDEO_BUF_DVB to a kconfig #ifdef test
for CONFIG_VIDEO_BUF_DVB, that would be acceptable.
Regards,
Michael Krufky
next prev parent reply other threads:[~2006-12-07 15:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 15:00 [2.6 patch] cx88/saa7134: remove unused -DHAVE_VIDEO_BUF_DVB Adrian Bunk
2006-12-07 15:36 ` Michael Krufky [this message]
2006-12-07 16:42 ` [v4l-dvb-maintainer] " Adrian Bunk
2006-12-07 17:13 ` Michael Krufky
2006-12-07 17:26 ` Adrian Bunk
2006-12-08 15:15 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457834E1.1090406@linuxtv.org \
--to=mkrufky@linuxtv.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox