From: Randy Dunlap <randy.dunlap@oracle.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Chris Friesen <cfriesen@nortel.com>,
lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>,
jesper.juhl@gmail.com
Subject: Re: [PATCH/RFC] CodingStyle updates
Date: Thu, 07 Dec 2006 13:36:53 -0800 [thread overview]
Message-ID: <45788975.1000401@oracle.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0612071927140.31022@yvahk01.tjqt.qr>
Jan Engelhardt wrote:
>>> What keyword is "defined"? Did you have too much Perl coffee? :)
>> Maybe macro formatting?
>>
>> #if defined(CONFIG_FOO)
Yes, that's it.
> Ah thanks for the hint. This also raises another stylistic aspect:
>
> #ifdef XYZ over #if defined(XYZ) when there is only one macro to be
> tested for.
I'm not sure that we care enough to put it into CodingStyle.
--
~Randy
next prev parent reply other threads:[~2006-12-07 21:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 8:48 [PATCH/RFC] CodingStyle updates Randy Dunlap
2006-12-07 8:54 ` Jesper Juhl
2006-12-07 11:11 ` Jan Engelhardt
2006-12-07 16:01 ` Chris Friesen
2006-12-07 18:27 ` Jan Engelhardt
2006-12-07 21:36 ` Randy Dunlap [this message]
2006-12-07 21:36 ` Randy Dunlap
2006-12-07 22:54 ` Alistair John Strachan
2006-12-07 23:00 ` Randy Dunlap
2006-12-07 23:06 ` David Miller
2006-12-07 23:15 ` Randy Dunlap
2006-12-07 23:23 ` Jan Engelhardt
2006-12-14 22:38 ` David Weinehall
2006-12-14 22:42 ` Randy Dunlap
2006-12-15 0:07 ` Robert P. J. Day
2006-12-15 0:26 ` Randy Dunlap
2006-12-15 0:44 ` Robert P. J. Day
2006-12-14 23:33 ` Scott Preece
2006-12-14 23:43 ` Randy Dunlap
2006-12-14 23:54 ` Scott Preece
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45788975.1000401@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@osdl.org \
--cc=cfriesen@nortel.com \
--cc=jengelh@linux01.gwdg.de \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox