From: Chris Lalancette <clalance@redhat.com>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: linux-net@vger.kernel.org, mpm@selenic.com, akpm@osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netpoll: make arp replies through netpoll use mac address of sender
Date: Thu, 07 Dec 2006 16:47:36 -0500 [thread overview]
Message-ID: <45788BF8.2010908@redhat.com> (raw)
In-Reply-To: <20061207194553.GB29313@hmsreliant.homelinux.net>
Neil Horman wrote:
> Back in 2.4 arp requests that were recevied by netpoll were processed in
> netconsole_receive_skb, where they were responded to using the src mac of the
> request sender. In the 2.6 kernel arp_reply is responsible for this function,
> but instead of using the src mac address of the incomming request, the stored
> mac address that was registered for the netconsole application is used. While
> this is usually ok, it can lead to failures in netpoll in some situations
> (specifically situations where a network may have two gateways, as arp requests
> from one may be responded to using the mac address of the other). This patch
> reverts the behavior to what we had in 2.4, in which all arp requests are sent
> back using the src address of the request sender.
>
> Thanks & Regards
> Neil
>
> Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
>
Neil and I worked on this together, adding my ACK
Acked-by: Chris Lalancette <clalance@redhat.com>
next prev parent reply other threads:[~2006-12-07 21:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-07 19:45 [PATCH] netpoll: make arp replies through netpoll use mac address of sender Neil Horman
2006-12-07 21:47 ` Chris Lalancette [this message]
2006-12-08 8:07 ` David Miller
2006-12-08 14:13 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45788BF8.2010908@redhat.com \
--to=clalance@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox