From: Rocky Craig <rocky.craig@hp.com>
To: Andrew Morton <akpm@osdl.org>
Cc: minyard@acm.org, Linux Kernel <linux-kernel@vger.kernel.org>,
OpenIPMI Developers <openipmi-developer@lists.sourceforge.net>
Subject: Re: [PATCH 11/12] IPMI: Fix BT long busy
Date: Fri, 08 Dec 2006 06:03:59 -0700 [thread overview]
Message-ID: <457962BF.5050202@hp.com> (raw)
In-Reply-To: <20061203132636.a7ac969d.akpm@osdl.org>
Andrew Morton wrote:
>In fact, please don't write macros.
>
>
I see them all over the place (i.e., EXPORT_SYMBOL) so the request
is a little confusing to me...
> Please don't write macros which require that the caller have a particular
>
>local variable of a particular name.
>
>
I could understand that, even if some people did agree with my desire
to increase legibility by decreasing visual clutter. I think it also
provides
some protection against typos in argument lists.
I'm (naively) curious as to why it's being flagged now as opposed to
two years ago when I submitted the original additions.
Have reviewers or review methods changed?
Have standards changed?
Did it just slip under someone's radar two years ago?
Regards,
Rocky Craig
HP Open Source and Linux Organization
next prev parent reply other threads:[~2006-12-08 13:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-02 4:39 [PATCH 11/12] IPMI: Fix BT long busy Corey Minyard
2006-12-03 21:26 ` Andrew Morton
2006-12-04 4:10 ` [Openipmi-developer] " Bela Lubkin
2006-12-08 13:03 ` Rocky Craig [this message]
2006-12-08 20:29 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457962BF.5050202@hp.com \
--to=rocky.craig@hp.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox