Re: RFC: PCI quirks update for 2.6.16

[Daniel Drake <dsd@gentoo.org>]

Adrian Bunk wrote:
> Below is the patch for going back to the 2.6.16.16 status quo that is in 
> 2.6.16.36-rc1.
> 
> Does this cause any serious regression for anyone?

If I remember right, it breaks Chris Wedgwood's box

> cu
> Adrian
> 
> 
> commit dcb1715778026c4aec20d186dc794245d9a1f5de
> Author: Adrian Bunk <bunk@stusta.de>
> Date:   Fri Dec 8 17:00:35 2006 +0100
> 
>     revert the quirk_via_irq changes
>     
>     This patch reverts the quirk_via_irq changes in 2.6.16.17 that
>     caused regressions for several people.
>     
>     Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> index a1cdf06..2a66e39 100644
> --- a/drivers/pci/quirks.c
> +++ b/drivers/pci/quirks.c
> @@ -656,13 +656,7 @@ static void quirk_via_irq(struct pci_dev *dev)
>  		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
>  	}
>  }
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_0, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_1, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_2, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C586_3, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_4, quirk_via_irq);
> -DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_DEVICE_ID_VIA_82C686_5, quirk_via_irq);
> +DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
>  
>  /*
>   * VIA VT82C598 has its device ID settable and many BIOSes
>