public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Keiichi KII <k-keiichi@bx.jp.nec.com>
To: mpm@selenic.com
Cc: linux-kernel@vger.kernel.org
Subject: [RFC][PATCH 2.6.19 5/6] add "add" element in /sys/class/misc/netconsole
Date: Tue, 12 Dec 2006 15:37:20 +0900	[thread overview]
Message-ID: <457E4E20.5090101@bx.jp.nec.com> (raw)
In-Reply-To: <457E498C.1050806@bx.jp.nec.com>

From: Keiichi KII <k-keiichi@bx.jp.nec.com>

This patch contains the following changes.

To add port dynamically, create "add" element in /sys/class/misc/netconsole.

ex)
1. echo "eth0" > /sys/clas/misc/netconsole/add
   then the port is added with the default settings.

2. echo "@/eth0,@192.168.0.1/" > /sys/class/misc/netconsole/add
   then the port is added with the settings sending kernel messages
   to 192.168.0.1 using eth0 device.

-+- /sys/class/misc/
 |-+- netconsole/
   |--- add       [-w-------]  If you write parameter(network interface name
   |                           or one config parameter of netconsole), The
   |                            port related its config is added
   |--- port1/
   |--- port2/
   ...

Signed-off-by: Keiichi KII <k-keiichi@bx.jp.nec.com>
---
--- linux-2.6.19/drivers/net/netconsole.c	2006-12-06 14:37:26.874827500 +0900
+++ enhanced-netconsole/drivers/net/netconsole.c.add	2006-12-06
13:33:05.661516750 +0900
@@ -321,6 +321,50 @@ static struct miscdevice netcon_miscdev
 	.name = "netconsole",
 };

+static ssize_t set_netconmisc_add(struct class_device *cdev, const char *buf,
+				  size_t count)
+{
+	char *target;
+	char *target_param;
+
+	target_param = (char*)kmalloc(count+1, GFP_ATOMIC);
+	if (!target_param) {
+		printk(KERN_INFO "netconsole: kmalloc() failed!\n");
+		return -ENOMEM;
+	}
+
+	strcpy(target_param, buf);
+	if (target_param[count - 1] == '\n') {
+		target_param[count - 1] = '\0';
+	}
+
+	if (dev_get_by_name(target_param)) {
+		printk(KERN_INFO "netconsole: device name = [%s]\n",
+		       target_param);
+		target = (char*)kmalloc(MAX_CONFIG_LENGTH+1, GFP_ATOMIC);
+		if (!target) {
+			printk(KERN_INFO "netconsole: kmalloc() failed!\n");
+			kfree(target_param);
+			return -ENOMEM;
+		}
+		sprintf(target,"@/%s,@/", target_param);
+		add_netcon_dev(target);
+		kfree(target);
+	} else {
+		printk(KERN_INFO "netconsole: config = [%s]\n", target_param);
+		add_netcon_dev(target_param);
+	}
+	kfree(target_param);
+
+	return count;
+}
+
+static CLASS_DEVICE_ATTR(add, S_IWUSR, NULL, set_netconmisc_add);
+
+static struct class_device_attribute *netcon_misc_attr[] = {
+	&class_device_attr_add,
+};
+
 static struct netpoll np = {
 	.name = "netconsole",
 	.dev_name = "eth0",
@@ -446,6 +490,7 @@ static int __init init_netconsole(void)
 {
 	char *p;
 	char *tmp = config;
+	int i = 0;

 	if (misc_register(&netcon_miscdev)) {
 		printk(KERN_INFO
@@ -456,6 +501,11 @@ static int __init init_netconsole(void)
 	}
 	register_console(&netconsole);

+	for(i=0; i < ARRAY_SIZE(netcon_misc_attr); i++) {
+		class_device_create_file(netcon_miscdev.class,
+					 netcon_misc_attr[i]);
+	}
+
 	if(!strlen(config)) {
 		printk(KERN_INFO "netconsole: not configured\n");
 		return 0;

-- 
Keiichi KII
NEC Corporation OSS Promotion Center
E-mail: k-keiichi@bx.jp.nec.com

  parent reply	other threads:[~2006-12-12  6:37 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-12  6:17 [RFC][PATCH 2.6.19 0/6] proposal for dynamic configurable netconsole Keiichi KII
2006-12-12  6:28 ` [RFC][PATCH 2.6.19 1/6] cleanup for netconsole Keiichi KII
2006-12-12 18:10   ` Matt Mackall
2006-12-12  6:34 ` [RFC][PATCH 2.6.19 3/6] add interface for netconsole using sysfs Keiichi KII
2006-12-12 19:09   ` Matt Mackall
2006-12-12  6:36 ` [RFC][PATCH 2.6.19 4/6] switch function of netpoll Keiichi KII
2006-12-12 19:15   ` Matt Mackall
2006-12-12  6:37 ` Keiichi KII [this message]
2006-12-12 19:27   ` [RFC][PATCH 2.6.19 5/6] add "add" element in /sys/class/misc/netconsole Matt Mackall
2006-12-12  6:38 ` [RFC][PATCH 2.6.19 6/6] update modification history Keiichi KII
2006-12-13 23:50   ` Stephen Hemminger
2006-12-12 18:13 ` [RFC][PATCH 2.6.19 0/6] proposal for dynamic configurable netconsole Matt Mackall
2006-12-13  9:44   ` Keiichi KII
     [not found] ` <457E4C65.6030802@bx.jp.nec.com>
2006-12-12 18:42   ` [RFC][PATCH 2.6.19 2/6] support multiple logging agents Matt Mackall
2006-12-13 21:16     ` Andy Isaacson
2006-12-20  9:35     ` Keiichi KII
2006-12-20 16:40       ` Matt Mackall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=457E4E20.5090101@bx.jp.nec.com \
    --to=k-keiichi@bx.jp.nec.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpm@selenic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox