Re: [PATCH -mm] sata_nv: add suspend/resume support

Jeff Garzik
2006-12-11T16:27:31Z

Robert Hancock wrote:
> +static void nv_remove_one (struct pci_dev *pdev)
> +{
> + struct ata_host *host = dev_get_drvdata(&pdev->dev);
> + struct nv_host_priv *hpriv = host->private_data;
> +
> + kfree(hpriv);
> + ata_pci_remove_one(pdev);
> +}

It is unwise to free the struct before the ports are even detached.

Otherwise, seems ok, but I would like to see some more positive user
reports (both ADMA and not) before pushing upstream.

Jeff