Re: [2.6 patch] drivers/kvm/: possible cleanups

Adrian Bunk
2006-12-12T12:56:01Z

On Tue, Dec 12, 2006 at 11:16:36AM +0200, Avi Kivity wrote:
> Adrian Bunk wrote:
> >This patch contains the following possible cleanups:
> >- make needlessly global code static
> >- proper prototype for kvm_main.c:find_msr_entry()
> >- #if 0 the unused svm.c:inject_db()
> >
> >
>
> Please copy kvm patches to kvm-devel@lists.sourceforge.net in the future.

-ENOMAINTAINERSENTRY ;-)

> find_msr_entry() has been moved to vmx.c by another patch (now queued in
> -mm), so this patch does not apply. The rest of the cleanups do look
> good though.
>
> While I'll accept cleanup patches for kvm, there are other sources of
> churn right now, so it might be more efficient to wait with the cleanups
> for a few weeks.

OK

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed