Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

Auke Kok
2006-12-12T18:32:53Z

Pekka Enberg wrote:
> On 12/12/06, Yan Burman <burman.yan@gmail.com> wrote:
>> size = txdr->count * sizeof(struct e1000_buffer);
>> - if (!(txdr->buffer_info = kmalloc(size, GFP_KERNEL))) {
>> + if (!(txdr->buffer_info = kzalloc(size, GFP_KERNEL))) {
>> ret_val = 1;
>> goto err_nomem;
>> }
>> - memset(txdr->buffer_info, 0, size);
>
> No one seems to be using size elsewhere so why not convert to
> kcalloc() and get rid of it? (Seems to apply to other places as well.)

I'll put it on my todo list.

Auke