From: "Darrick J. Wong" <djwong@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Douglas Gilbert <dougg@torque.net>
Subject: Re: [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices
Date: Tue, 12 Dec 2006 14:24:28 -0800 [thread overview]
Message-ID: <457F2C1C.1030503@us.ibm.com> (raw)
In-Reply-To: <1165855489.2791.7.camel@mulgrave.il.steeleye.com>
James Bottomley wrote:
> I thought we were closing in on agreeing that the SPC/MMC
> inconsistencies made this the correct candidate fix.
I tried out the patch below, but with it applied, SCSI still issues
REPORT LUNS to the device. It seems that sdev->type = -1 and bflags = 0
when scsi_get_device_flags is called because the type code is not set up
until scsi_add_lun, which is called later. In any case, the check
doesn't work for me because the SATAPI GoVault reports itself as a
Direct Access device, not a CD-ROM.
> diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
<snip>
> diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
<empty>
Was there supposed to be more to this patch?
--D
next prev parent reply other threads:[~2006-12-12 22:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-04 23:02 libata: Simulate REPORT LUNS for ATAPI devices when not supported Darrick J. Wong
2006-12-04 23:12 ` Jeff Garzik
2006-12-04 23:32 ` [PATCH v2] libata: Simulate REPORT LUNS for ATAPI devices Darrick J. Wong
2006-12-07 12:20 ` Jeff Garzik
2006-12-07 15:47 ` Douglas Gilbert
2006-12-07 18:09 ` James Bottomley
2006-12-07 19:13 ` Douglas Gilbert
2006-12-11 16:24 ` Jeff Garzik
2006-12-11 16:44 ` James Bottomley
2006-12-11 16:59 ` Jeff Garzik
2006-12-12 22:24 ` Darrick J. Wong [this message]
2006-12-13 16:10 ` James Bottomley
2006-12-13 17:38 ` Darrick J. Wong
2006-12-13 17:57 ` James Bottomley
2006-12-13 18:56 ` Patrick Mansfield
2006-12-13 20:06 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=457F2C1C.1030503@us.ibm.com \
--to=djwong@us.ibm.com \
--cc=James.Bottomley@SteelEye.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougg@torque.net \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox