[PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Sergei Shtylyov]

Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE controller,
completely reworked from the original brain-damaged Toshiba's 2.4 version.

This single channel UltraDMA/66 controller is very simple in programming, yet
Toshiba managed to plant many interesting bugs in it.  The particularly nasty
"limitation 5" (as they call the errata) caused me to abuse the IDE core in a
possibly most interesting way so far.  However, this is still better than the
#ifdef mess in drivers/ide/ide-io.c that the original version included (well,
it had much more mess)...

Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

 drivers/ide/Kconfig        |    5 
 drivers/ide/pci/Makefile   |    1 
 drivers/ide/pci/tc86c001.c |  304 +++++++++++++++++++++++++++++++++++++++++++++
 drivers/pci/quirks.c       |   18 ++
 include/linux/pci_ids.h    |    1 
 5 files changed, 329 insertions(+)

Index: linux-2.6/drivers/ide/Kconfig
===================================================================
--- linux-2.6.orig/drivers/ide/Kconfig
+++ linux-2.6/drivers/ide/Kconfig
@@ -742,6 +742,11 @@ config BLK_DEV_VIA82CXXX
 	  This allows the kernel to change PIO, DMA and UDMA speeds and to
 	  configure the chip to optimum performance.
 
+config BLK_DEV_TC86C001
+	tristate "Toshiba TC86C001 support"
+	help
+	This driver adds support for Toshiba TC86C001 GOKU-S chip.
+
 endif
 
 config BLK_DEV_IDE_PMAC
Index: linux-2.6/drivers/ide/pci/Makefile
===================================================================
--- linux-2.6.orig/drivers/ide/pci/Makefile
+++ linux-2.6/drivers/ide/pci/Makefile
@@ -26,6 +26,7 @@ obj-$(CONFIG_BLK_DEV_SIIMAGE)		+= siimag
 obj-$(CONFIG_BLK_DEV_SIS5513)		+= sis5513.o
 obj-$(CONFIG_BLK_DEV_SL82C105)		+= sl82c105.o
 obj-$(CONFIG_BLK_DEV_SLC90E66)		+= slc90e66.o
+obj-$(CONFIG_BLK_DEV_TC86C001)		+= tc86c001.o
 obj-$(CONFIG_BLK_DEV_TRIFLEX)		+= triflex.o
 obj-$(CONFIG_BLK_DEV_TRM290)		+= trm290.o
 obj-$(CONFIG_BLK_DEV_VIA82CXXX)		+= via82cxxx.o
Index: linux-2.6/drivers/ide/pci/tc86c001.c
===================================================================
--- /dev/null
+++ linux-2.6/drivers/ide/pci/tc86c001.c
@@ -0,0 +1,304 @@
+/*
+ * drivers/ide/pci/tc86c001.c	Version 1.00	Dec 12, 2006
+ *
+ * Copyright (C) 2002 Toshiba Corporation
+ * Copyright (C) 2005-2006 MontaVista Software, Inc. <source@mvista.com>
+ *
+ * This file is licensed under the terms of the GNU General Public
+ * License version 2.  This program is licensed "as is" without any
+ * warranty of any kind, whether express or implied.
+ */
+
+#include <linux/types.h>
+#include <linux/pci.h>
+#include <linux/ide.h>
+
+static inline u8 tc86c001_ratemask(ide_drive_t *drive)
+{
+	return eighty_ninty_three(drive) ? 2 : 1;
+}
+
+static int tc86c001_tune_chipset(ide_drive_t *drive, u8 speed)
+{
+	ide_hwif_t *hwif	= HWIF(drive);
+	unsigned long scr_port	= hwif->config_data + (drive->dn ? 0x02 : 0x00);
+	u16 mode, scr		= hwif->INW(scr_port);
+
+	speed = ide_rate_filter(tc86c001_ratemask(drive), speed);
+
+	switch (speed) {
+		case XFER_UDMA_4:	mode = 0x00c0; break;
+		case XFER_UDMA_3:	mode = 0x00b0; break;
+		case XFER_UDMA_2:	mode = 0x00a0; break;
+		case XFER_UDMA_1:	mode = 0x0090; break;
+		case XFER_UDMA_0:	mode = 0x0080; break;
+		case XFER_MW_DMA_2:	mode = 0x0070; break;
+		case XFER_MW_DMA_1:	mode = 0x0060; break;
+		case XFER_MW_DMA_0:	mode = 0x0050; break;
+		case XFER_PIO_4:	mode = 0x0400; break;
+		case XFER_PIO_3:	mode = 0x0300; break;
+		case XFER_PIO_2:	mode = 0x0200; break;
+		case XFER_PIO_1:	mode = 0x0100; break;
+		case XFER_PIO_0:
+		default:		mode = 0x0000; break;
+	}
+
+	scr &= (speed < XFER_MW_DMA_0) ? 0xf8ff : 0xff0f;
+	scr |= mode;
+	hwif->OUTW(scr, scr_port);
+
+	return ide_config_drive_speed(drive, speed);
+}
+
+static void tc86c001_tune_drive(ide_drive_t *drive, u8 pio)
+{
+	pio =  ide_get_best_pio_mode(drive, pio, 4, NULL);
+	(void) tc86c001_tune_chipset(drive, XFER_PIO_0 + pio);
+}
+
+/*
+ * HACKITY HACK
+ *
+ * This is a workaround for the limitation 5 of the TC86C001 IDE controller:
+ * if a DMA transfer terminates prematurely, the controller leaves the device's
+ * interrupt request (INTRQ) pending and does not generate a PCI interrupt (or
+ * set the interrupt bit in the DMA status register), thus no PCI interrupt
+ * will occur until a DMA transfer has been successfully completed.
+ *
+ * We work around this by initiating dummy, zero-length DMA transfer on
+ * a DMA timeout expiration. I found no better way to do this with the current
+ * IDE core than to temporarily replace a higher level driver's timer expiry
+ * handler with our own backing up to that handler in case our recovery fails.
+ */
+static int tc86c001_timer_expiry(ide_drive_t *drive)
+{
+	ide_hwif_t *hwif	= HWIF(drive);
+	ide_expiry_t *expiry	= ide_get_hwifdata(hwif);
+	ide_hwgroup_t *hwgroup	= HWGROUP(drive);
+	u8 dma_stat		= hwif->INB(hwif->dma_status);
+
+	/* Restore a higher level driver's expiry handler first. */
+	hwgroup->expiry	= expiry;
+
+	if ((dma_stat & 5) == 1) {	/* DMA active and no interrupt */
+		unsigned long sc_base	= hwif->config_data;
+		unsigned long twcr_port	= sc_base + (drive->dn ? 0x06 : 0x04);
+		u8 dma_cmd		= hwif->INB(hwif->dma_command);
+
+		printk(KERN_WARNING "%s: DMA interrupt possibly stuck, "
+		       "attempting recovery...\n", drive->name);
+
+		/* Stop DMA */
+		hwif->OUTB(dma_cmd & ~0x01, hwif->dma_command);
+
+		/* Setup the dummy DMA transfer */
+		hwif->OUTW(0, sc_base + 0x0a);	/* Sector Count */
+		hwif->OUTW(0, twcr_port);	/* Transfer Word Count 1 or 2 */
+
+		/* Start the dummy DMA transfer */
+		hwif->OUTB(0x00, hwif->dma_command); /* clear R_OR_WCTR for write */
+		hwif->OUTB(0x01, hwif->dma_command); /* set START_STOPBM */
+
+		/*
+		 * If an interrupt was pending, it should come thru shortly.
+		 * If not, higher level driver's expiry code should eventually
+		 * cause some kind of recovery from the DMA stall...
+		 */
+		return WAIT_MIN_SLEEP;
+	}
+
+	/* Chain to the restored expiry handler if DMA wasn't active. */
+	if (likely(expiry != NULL))
+		return expiry(drive);
+
+	/* If there was no handler, "emulate" that for ide_timer_expiry()... */
+	return -1;
+}
+
+static void tc86c001_dma_start(ide_drive_t *drive)
+{
+	ide_hwif_t *hwif	= HWIF(drive);
+	ide_hwgroup_t *hwgroup	= HWGROUP(drive);
+	unsigned long sc_base	= hwif->config_data;
+	unsigned long twcr_port	= sc_base + (drive->dn ? 0x06 : 0x04);
+	unsigned long nsectors	= hwgroup->rq->nr_sectors;
+
+	/*
+	 * We have to manually load the sector count and size into
+	 * the appropriate system control registers for DMA to work
+	 * with LBA48 and ATAPI devices...
+	 */
+	hwif->OUTW(nsectors, sc_base + 0x0a);	/* Sector Count */
+	hwif->OUTW(SECTOR_SIZE / 2, twcr_port); /* Transfer Word Count 1/2 */
+
+	/* Install our timeout expiry hook, saving the current handler... */
+	ide_set_hwifdata(hwif, hwgroup->expiry);
+	hwgroup->expiry = &tc86c001_timer_expiry;
+
+	ide_dma_start(drive);
+}
+
+static int tc86c001_busproc(ide_drive_t *drive, int state)
+{
+	ide_hwif_t *hwif	= HWIF(drive);
+	unsigned long sc_base	= hwif->config_data;
+	u16 scr1;
+
+	/* System Control 1 Register bit 11 (ATA Hard Reset) read */
+	scr1 = hwif->INW(sc_base + 0x00);
+
+	switch (state) {
+		case BUSSTATE_ON:
+			if (!(scr1 & 0x0800))
+				return 0;
+			scr1 &= ~0x0800;
+
+			hwif->drives[0].failures = hwif->drives[1].failures = 0;
+			break;
+		case BUSSTATE_OFF:
+			if (scr1 & 0x0800)
+				return 0;
+			scr1 |= 0x0800;
+
+			hwif->drives[0].failures = hwif->drives[0].max_failures + 1;
+			hwif->drives[1].failures = hwif->drives[1].max_failures + 1;
+			break;
+		default:
+			return -EINVAL;
+	}
+
+	/* System Control 1 Register bit 11 (ATA Hard Reset) write */
+	hwif->OUTW(scr1, sc_base + 0x00);
+	return 0;
+}
+
+static int config_chipset_for_dma(ide_drive_t *drive)
+{
+	u8 speed = ide_dma_speed(drive, tc86c001_ratemask(drive));
+
+	if (!speed)
+		return 0;
+
+	(void) tc86c001_tune_chipset(drive, speed);
+	return ide_dma_enable(drive);
+}
+
+static int tc86c001_config_drive_xfer_rate(ide_drive_t *drive)
+{
+	ide_hwif_t *hwif	= HWIF(drive);
+	struct hd_driveid *id	= drive->id;
+
+	if ((id->capability & 1) && drive->autodma) {
+
+		if (ide_use_dma(drive) && config_chipset_for_dma(drive))
+			return hwif->ide_dma_on(drive);
+
+		goto fast_ata_pio;
+
+	} else if ((id->capability & 8) || (id->field_valid & 2)) {
+fast_ata_pio:
+		tc86c001_tune_drive(drive, 5);
+		return hwif->ide_dma_off_quietly(drive);
+	}
+	/* IORDY not supported */
+	return 0;
+}
+
+void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
+{
+	unsigned long sc_base	= pci_resource_start(hwif->pci_dev, 5);
+	u16 scr1		= hwif->INW(sc_base + 0x00);;
+
+	/* System Control 1 Register bit 15 (Soft Reset) set */
+	hwif->OUTW(scr1 |  0x8000, sc_base + 0x00);
+
+	/* System Control 1 Register bit 14 (FIFO Reset) set */
+	hwif->OUTW(scr1 |  0x4000, sc_base + 0x00);
+
+	/* System Control 1 Register: reset clear */
+	hwif->OUTW(scr1 & ~0xc000, sc_base + 0x00);
+
+	/* Store the system control register base for convenience... */
+	hwif->config_data = sc_base;
+
+	hwif->tuneproc	= &tc86c001_tune_drive;
+	hwif->speedproc = &tc86c001_tune_chipset;
+	hwif->busproc	= &tc86c001_busproc;
+
+	hwif->drives[0].autotune = hwif->drives[1].autotune = 1;
+
+	if (!hwif->dma_base)
+		return;
+
+	/*
+	 * Sector Count Control Register bits 0 and 1 set:
+	 * software sets Sector Count Register for master and slave device
+	 */
+	hwif->OUTW(0x0003, sc_base + 0x0c);
+
+	/* Sector Count Register limit */
+	hwif->rqsize	 = 0xffff;
+
+	hwif->atapi_dma  = 1;
+	hwif->ultra_mask = 0x1f;
+	hwif->mwdma_mask = 0x07;
+
+	hwif->ide_dma_check	= &tc86c001_config_drive_xfer_rate;
+	hwif->dma_start 	= &tc86c001_dma_start;
+
+	if (!hwif->udma_four) {
+		/*
+		 * System Control  1 Register bit 13 (PDIAGN):
+		 * 0=80-pin cable, 1=40-pin cable
+		 */
+		scr1 = hwif->INW(sc_base + 0x00);
+		hwif->udma_four = (scr1 & 0x2000) ? 0 : 1;
+	}
+
+	if (!noautodma)
+		hwif->autodma = 1;
+	hwif->drives[0].autodma = hwif->drives[1].autodma = hwif->autodma;
+}
+
+static unsigned int init_chipset_tc86c001(struct pci_dev *dev, const char *name)
+{
+	return pci_request_region(dev, 5, "TC86C001");
+}
+
+static ide_pci_device_t tc86c001_chipset __devinitdata = {
+	.name		= "TC86C001",
+	.init_chipset	= init_chipset_tc86c001,
+	.init_hwif	= init_hwif_tc86c001,
+	.channels	= 1,
+	.autodma	= AUTODMA,
+	.bootable	= OFF_BOARD
+};
+
+static int __devinit tc86c001_init_one(struct pci_dev *dev,
+				       const struct pci_device_id *id)
+{
+	return ide_setup_pci_device(dev, &tc86c001_chipset);
+}
+
+static struct pci_device_id tc86c001_pci_tbl[] = {
+	{ PCI_VENDOR_ID_TOSHIBA_2, PCI_DEVICE_ID_TOSHIBA_TC86C001_IDE,
+	  PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
+	{ 0, }
+};
+MODULE_DEVICE_TABLE(pci, tc86c001_pci_tbl);
+
+static struct pci_driver driver = {
+	.name		= "TC86C001",
+	.id_table	= tc86c001_pci_tbl,
+	.probe		= tc86c001_init_one
+};
+
+static int tc86c001_ide_init(void)
+{
+	return ide_pci_register_driver(&driver);
+}
+module_init(tc86c001_ide_init);
+
+MODULE_AUTHOR("MontaVista Software, Inc. <source@mvista.com>");
+MODULE_DESCRIPTION("PCI driver module for TC86C001 IDE");
+MODULE_LICENSE("GPL");
Index: linux-2.6/drivers/pci/quirks.c
===================================================================
--- linux-2.6.orig/drivers/pci/quirks.c
+++ linux-2.6/drivers/pci/quirks.c
@@ -1407,6 +1407,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260a, quirk_intel_pcie_pm);
 DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);
 
+/*
+ * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
+ * but PIO transfer won't work if BAR0 falls at the odd 8 bytes.
+ * Re-allocate the region if needed.
+ */
+static void __init quirk_tc86c001_ide(struct pci_dev *dev)
+{
+	struct resource *r = &dev->resource[0];
+
+	if (r->start & 0x8) {
+		r->start = 0;
+		r->end = 0xf;
+	}
+}
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_TOSHIBA_2,
+			 PCI_DEVICE_ID_TOSHIBA_TC86C001_IDE,
+			 quirk_tc86c001_ide );
+
 static void __devinit quirk_netmos(struct pci_dev *dev)
 {
 	unsigned int num_parallel = (dev->subsystem_device & 0xf0) >> 4;
Index: linux-2.6/include/linux/pci_ids.h
===================================================================
--- linux-2.6.orig/include/linux/pci_ids.h
+++ linux-2.6/include/linux/pci_ids.h
@@ -1444,6 +1444,7 @@
 
 #define PCI_VENDOR_ID_TOSHIBA_2		0x102f
 #define PCI_DEVICE_ID_TOSHIBA_TC35815CF	0x0030
+#define PCI_DEVICE_ID_TOSHIBA_TC86C001_IDE	0x0105
 #define PCI_DEVICE_ID_TOSHIBA_TC86C001_MISC	0x0108
 #define PCI_DEVICE_ID_TOSHIBA_SPIDER_NET 0x01b3
 

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Sergei Shtylyov]

Hello.

On Wednesday 13 December 2006 01:48, Sergei Shtylyov wrote:
> Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE controller,
> completely reworked from the original brain-damaged Toshiba's 2.4 version.

   Shoot, the patch is actually against the most recent Linus' tree, so
it's 2.6.20-rc1...

   Andrew, 2.6.19-rc6-mm2 series keeps failing to completely apply to 
2.6.19-rc6 head in my git repo -- don't know why, maybe that's my git...
Hence the patch was againt Linus' tree.

WBR, Sergei

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Randy Dunlap]

On Wed, 13 Dec 2006 01:48:34 +0300 Sergei Shtylyov wrote:

> Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE controller,
> completely reworked from the original brain-damaged Toshiba's 2.4 version.
> 
> This single channel UltraDMA/66 controller is very simple in programming, yet
> Toshiba managed to plant many interesting bugs in it.  The particularly nasty
> "limitation 5" (as they call the errata) caused me to abuse the IDE core in a
> possibly most interesting way so far.  However, this is still better than the
> #ifdef mess in drivers/ide/ide-io.c that the original version included (well,
> it had much more mess)...
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
>  drivers/ide/Kconfig        |    5 
>  drivers/ide/pci/Makefile   |    1 
>  drivers/ide/pci/tc86c001.c |  304 +++++++++++++++++++++++++++++++++++++++++++++
>  drivers/pci/quirks.c       |   18 ++
>  include/linux/pci_ids.h    |    1 
>  5 files changed, 329 insertions(+)
> 
> Index: linux-2.6/drivers/ide/Kconfig
> ===================================================================
> --- linux-2.6.orig/drivers/ide/Kconfig
> +++ linux-2.6/drivers/ide/Kconfig
> @@ -742,6 +742,11 @@ config BLK_DEV_VIA82CXXX
>  	  This allows the kernel to change PIO, DMA and UDMA speeds and to
>  	  configure the chip to optimum performance.
>  
> +config BLK_DEV_TC86C001
> +	tristate "Toshiba TC86C001 support"

Needs something here like lots of other IDE PCI drivers have:
	depends on PCI && BLK_DEV_IDEPCI

or at least:  depends on PCI


> +	help
> +	This driver adds support for Toshiba TC86C001 GOKU-S chip.
> +
>  endif

---
~Randy

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Sergei Shtylyov]

Hello.

Randy Dunlap wrote:

>>Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE controller,
>>completely reworked from the original brain-damaged Toshiba's 2.4 version.
>>
>>This single channel UltraDMA/66 controller is very simple in programming, yet
>>Toshiba managed to plant many interesting bugs in it.  The particularly nasty
>>"limitation 5" (as they call the errata) caused me to abuse the IDE core in a
>>possibly most interesting way so far.  However, this is still better than the
>>#ifdef mess in drivers/ide/ide-io.c that the original version included (well,
>>it had much more mess)...

>>Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

>> drivers/ide/Kconfig        |    5 
>> drivers/ide/pci/Makefile   |    1 
>> drivers/ide/pci/tc86c001.c |  304 +++++++++++++++++++++++++++++++++++++++++++++
>> drivers/pci/quirks.c       |   18 ++
>> include/linux/pci_ids.h    |    1 
>> 5 files changed, 329 insertions(+)
>>
>>Index: linux-2.6/drivers/ide/Kconfig
>>===================================================================
>>--- linux-2.6.orig/drivers/ide/Kconfig
>>+++ linux-2.6/drivers/ide/Kconfig
>>@@ -742,6 +742,11 @@ config BLK_DEV_VIA82CXXX
>> 	  This allows the kernel to change PIO, DMA and UDMA speeds and to
>> 	  configure the chip to optimum performance.
>> 
>>+config BLK_DEV_TC86C001
>>+	tristate "Toshiba TC86C001 support"

> Needs something here like lots of other IDE PCI drivers have:
> 	depends on PCI && BLK_DEV_IDEPCI

> or at least:  depends on PCI

    No, it's already under if BLK_DEV_IDEPCI. And if you really look into 
Kconfig you'll see hwo it's done there...

>>+	help
>>+	This driver adds support for Toshiba TC86C001 GOKU-S chip.
>>+
>> endif

    Here's that endif.

WBR, Sergei

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Randy Dunlap]

Sergei Shtylyov wrote:
> Hello.
> 
> Randy Dunlap wrote:
> 
>>> Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE 
>>> controller,
>>> completely reworked from the original brain-damaged Toshiba's 2.4 
>>> version.
>>>
>>> This single channel UltraDMA/66 controller is very simple in 
>>> programming, yet
>>> Toshiba managed to plant many interesting bugs in it.  The 
>>> particularly nasty
>>> "limitation 5" (as they call the errata) caused me to abuse the IDE 
>>> core in a
>>> possibly most interesting way so far.  However, this is still better 
>>> than the
>>> #ifdef mess in drivers/ide/ide-io.c that the original version 
>>> included (well,
>>> it had much more mess)...
> 
>>> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
> 
>>> drivers/ide/Kconfig        |    5 drivers/ide/pci/Makefile   |    1 
>>> drivers/ide/pci/tc86c001.c |  304 
>>> +++++++++++++++++++++++++++++++++++++++++++++
>>> drivers/pci/quirks.c       |   18 ++
>>> include/linux/pci_ids.h    |    1 5 files changed, 329 insertions(+)
>>>
>>> Index: linux-2.6/drivers/ide/Kconfig
>>> ===================================================================
>>> --- linux-2.6.orig/drivers/ide/Kconfig
>>> +++ linux-2.6/drivers/ide/Kconfig
>>> @@ -742,6 +742,11 @@ config BLK_DEV_VIA82CXXX
>>>       This allows the kernel to change PIO, DMA and UDMA speeds and to
>>>       configure the chip to optimum performance.
>>>
>>> +config BLK_DEV_TC86C001
>>> +    tristate "Toshiba TC86C001 support"
> 
>> Needs something here like lots of other IDE PCI drivers have:
>>     depends on PCI && BLK_DEV_IDEPCI
> 
>> or at least:  depends on PCI
> 
>    No, it's already under if BLK_DEV_IDEPCI. And if you really look into 
> Kconfig you'll see hwo it's done there...
> 
>>> +    help
>>> +    This driver adds support for Toshiba TC86C001 GOKU-S chip.
>>> +
>>> endif
> 
>    Here's that endif.

Ack.  Thanks.

-- 
~Randy

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Alan]

> + * We work around this by initiating dummy, zero-length DMA transfer on
> + * a DMA timeout expiration. I found no better way to do this with the current

Novel workaround and probably better than resetting the chip as the
winbong does.

> +static int tc86c001_busproc(ide_drive_t *drive, int state)
> +{

Waste of space having a busproc routine. The maintainer removed all the
usable hotplug support from old IDE so this might as well be dropped.

> @@ -1407,6 +1407,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260a, quirk_intel_pcie_pm);
>  DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);
>  
> +/*
> + * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
> + * but PIO transfer won't work if BAR0 falls at the odd 8 bytes.
> + * Re-allocate the region if needed.
> + */

NAK. I think this fixup should be testing if the device port 0 is in
native mode before doing the fixup. In comaptibility mode bar 0 is
ignored and the correct compatibility values set up in the resource tree
by the PCI layer as of 2.6.18-mm-mumble. They are also of course on a xx0
boundary.

"Close but no cookie": please fix the PCI quirk to match the current -mm
behaviour with the ATA resource tree. Otherwise - nice driver.

Alan

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Alan]

On Wed, 13 Dec 2006 01:48:34 +0300
Sergei Shtylyov <sshtylyov@ru.mvista.com> wrote:

> Behold!  This is the driver for the Toshiba TC86C001 GOKU-S IDE controller,
> completely reworked from the original brain-damaged Toshiba's 2.4 version.

Actually un-nack the PCI quirk. While it is true the native mode is
relevant because of the way the BAR values work we know legacy bar values
are never "& 8" so the test is sufficient [but should be commented about
the assumption]

Alan

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Bartlomiej Zolnierkiewicz]

On 12/13/06, Alan <alan@lxorguk.ukuu.org.uk> wrote:

> > +static int tc86c001_busproc(ide_drive_t *drive, int state)
> > +{
>
> Waste of space having a busproc routine. The maintainer removed all the
> usable hotplug support from old IDE so this might as well be dropped.

I took over IDE when hotplug was already broken (late 2.5), moreover IDE
hotplug support has been always a quick hack according to its original author...
I remember your great efforts to fix it but unfortunately they
depended on executing
ioctls on non-existing devices which made them depend on layering
violation in 2.6,
also IDE device model fixes has some conflicts with them.  I take the
blame for not
applying them (for the reasons given above) and for taking much too
long in reviewing/testing them (due to lack of time not bad intention)
but accusing me of
intentional feature removal is going a bit too far...  You can hate me
all you want
for the way I did my entirely volunteer and unpaid job (but hey there
were and still is shortage of ATA hackers and there weren't anybody to
step up and takeover IDE)
but I actually have always taken responsibility/blame for all my
patches and patches
I accepted so if you really think I intentionally removed some usable
hotplug support
please point me to specific patch and describe the regression after
applying this
specific patch and I will do my best to have this regression fixed...

Bart

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Alan]

> > Waste of space having a busproc routine. The maintainer removed all the
> > usable hotplug support from old IDE so this might as well be dropped.
> 
> I took over IDE when hotplug was already broken (late 2.5), moreover IDE
> hotplug support has been always a quick hack according to its original author...
> I remember your great efforts to fix it but unfortunately they
> depended on executing
> ioctls on non-existing devices which made them depend on layering
> violation in 2.6,

Bart, I'm really not interested in a 500 email rehash of the fact you
chose to refuse the hotplug support (that was working) for 2.6.x. You
did, the world has moved on, and there is no point putting a busproc
function in that driver.

Do something useful. Send a patch to make Sergei the IDE maintainer as
he's doing all the IDE stuff these days.

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Bartlomiej Zolnierkiewicz]

On 12/13/06, Alan <alan@lxorguk.ukuu.org.uk> wrote:
> > > Waste of space having a busproc routine. The maintainer removed all the
> > > usable hotplug support from old IDE so this might as well be dropped.
> >
> > I took over IDE when hotplug was already broken (late 2.5), moreover IDE
> > hotplug support has been always a quick hack according to its original author...
> > I remember your great efforts to fix it but unfortunately they
> > depended on executing
> > ioctls on non-existing devices which made them depend on layering
> > violation in 2.6,
>
> Bart, I'm really not interested in a 500 email rehash of the fact you
> chose to refuse the hotplug support (that was working) for 2.6.x. You
> did, the world has moved on, and there is no point putting a busproc
> function in that driver.

Unfortunately it seems that not everybody has moved on.  It is not
about your not accepted patches but about "the maintainer removed
all the usable hotplug support from old IDE" false accusations which
are unproven and untrue.

Bart

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Alan]

> Unfortunately it seems that not everybody has moved on.  It is not
> about your not accepted patches but about "the maintainer removed
> all the usable hotplug support from old IDE" false accusations which
> are unproven and untrue.

I invite anyone who cares to study the archive.

Welcome back to my killfile.

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Sergei Shtylyov]

Hello.

Alan wrote:

>>+ * We work around this by initiating dummy, zero-length DMA transfer on
>>+ * a DMA timeout expiration. I found no better way to do this with the current

> Novel workaround and probably better than resetting the chip as the
> winbong does.

    I didn't try resetting however the datasheet suggests it just won't do.

>>+static int tc86c001_busproc(ide_drive_t *drive, int state)
>>+{

> Waste of space having a busproc routine. The maintainer removed all the
> usable hotplug support from old IDE so this might as well be dropped.

    Don't know what you mean, ioctl is still there...

>>@@ -1407,6 +1407,24 @@ DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_IN
>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260a, quirk_intel_pcie_pm);
>> DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL,	0x260b, quirk_intel_pcie_pm);

>>+/*
>>+ * Toshiba TC86C001 IDE controller reports the standard 8-byte BAR0 size
>>+ * but PIO transfer won't work if BAR0 falls at the odd 8 bytes.
>>+ * Re-allocate the region if needed.
>>+ */

> NAK. I think this fixup should be testing if the device port 0 is in
> native mode before doing the fixup. In comaptibility mode bar 0 is

    The chip is native mode only.

> "Close but no cookie": please fix the PCI quirk to match the current -mm
> behaviour with the ATA resource tree. Otherwise - nice driver.

    Ugh, I should've expected some backstab from -mm tree...

> Alan

WBR, Sergei

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Bartlomiej Zolnierkiewicz]

On 12/13/06, Alan <alan@lxorguk.ukuu.org.uk> wrote:
> > Unfortunately it seems that not everybody has moved on.  It is not
> > about your not accepted patches but about "the maintainer removed
> > all the usable hotplug support from old IDE" false accusations which
> > are unproven and untrue.

Moreover I could be just bypassed (which happened quite a few times in the
past) and you could get your patches accepted anyway.  And this indeed did
happened for some of your IDE patches but not for "working" hotplug support.
Strange, isn't?  So accept the damn fact that your hotplug support was far
from being acceptable and move on finally...

> I invite anyone who cares to study the archive.

I also invite anyone to study the archive.

> Welcome back to my killfile.

A novel way to prove your statements...

Bart

Re: [PATCH 2.6.19-rc1] Toshiba TC86C001 IDE driver

[Alan]

> >>+static int tc86c001_busproc(ide_drive_t *drive, int state)
> >>+{
> 
> > Waste of space having a busproc routine. The maintainer removed all the
> > usable hotplug support from old IDE so this might as well be dropped.
> 
>     Don't know what you mean, ioctl is still there...

You can turn the bus on and off but there is no ability to actually swap
drives except in RHEL4 and 2.4.x-ac kernels. Hence "waste of space"

> > "Close but no cookie": please fix the PCI quirk to match the current -mm
> > behaviour with the ATA resource tree. Otherwise - nice driver.
> 
>     Ugh, I should've expected some backstab from -mm tree...

If it is native only then there are no problems with the quirk 

Acked-by: Alan Cox <alan@redhat.com>