public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared
@ 2006-12-14 15:55 Pierre Peiffer
  2006-12-14 20:18 ` Ingo Molnar
  0 siblings, 1 reply; 2+ messages in thread
From: Pierre Peiffer @ 2006-12-14 15:55 UTC (permalink / raw)
  To: LKML; +Cc: Ingo Molnar, suresh.b.siddha

Hi,

The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are set, and 
CONFIG_NO_HZ isn't.

Is this patch correct ?

---

Index: linux-2.6.19-rt14-test/kernel/sched.c
===================================================================
--- linux-2.6.19-rt14-test.orig/kernel/sched.c  2006-12-14 16:27:37.000000000 +0100
+++ linux-2.6.19-rt14-test/kernel/sched.c       2006-12-14 16:42:38.000000000 +0100
@@ -4131,7 +4131,7 @@ switch_tasks:
                 ++*switch_count;

                 prepare_task_switch(rq, next);
-#if defined(CONFIG_HZ) && defined(CONFIG_SMP)
+#if defined(CONFIG_NO_HZ) && defined(CONFIG_SMP)
                 if (prev == rq->idle && notick.load_balancer == -1) {
                         /*
                          * simple selection for now: Nominate the first cpu in


Thanks,

-- 
Pierre Peiffer

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared
  2006-12-14 15:55 [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared Pierre Peiffer
@ 2006-12-14 20:18 ` Ingo Molnar
  0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2006-12-14 20:18 UTC (permalink / raw)
  To: Pierre Peiffer; +Cc: LKML, suresh.b.siddha


* Pierre Peiffer <pierre.peiffer@bull.net> wrote:

> Hi,
> 
> The kernel (sched.c) does not compile if CONFIG_HZ and CONFIG_SMP are 
> set, and CONFIG_NO_HZ isn't.

oops - indeed.

> Is this patch correct ?

yeah. (FYI, i had to hand-apply it because it had whitespace damage, all 
tabs where spaces)

	Ingo

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-12-14 20:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-12-14 15:55 [PATCH 2.6.19-rt14][BUG] kernel/sched.c:4135: error: 'notick' undeclared Pierre Peiffer
2006-12-14 20:18 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox