From: Sylvain Munaut <tnt@246tNt.com>
To: tglx@linutronix.de
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ingo Molnar <mingo@elte.hu>
Subject: Re: [PATCH] genirq: fix irq flow handler uninstall
Date: Fri, 15 Dec 2006 21:12:39 +0100 [thread overview]
Message-ID: <458301B7.5080609@246tNt.com> (raw)
In-Reply-To: <1166181714.29505.171.camel@localhost.localdomain>
Thomas Gleixner wrote:
> The sanity check for no_irq_chip in __set_irq_hander() is unconditional
> on both install and uninstall of an handler. This triggers false
> warnings and replaces no_irq_chip by dummy_irq_chip in the uninstall
> case.
>
> Check only, when a real handler is installed.
>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
>
Acked-by: Sylvain Munaut <tnt@246tNt.com>
Definitly fixed the spurious warning.
Sylvain
prev parent reply other threads:[~2006-12-15 20:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 11:21 [PATCH] genirq: fix irq flow handler uninstall Thomas Gleixner
2006-12-15 20:12 ` Sylvain Munaut [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=458301B7.5080609@246tNt.com \
--to=tnt@246tnt.com \
--cc=akpm@osdl.org \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox