From: Jeff Garzik <jgarzik@pobox.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pata_via: Cable detect error
Date: Sat, 16 Dec 2006 10:47:49 -0500 [thread overview]
Message-ID: <45841525.7040406@pobox.com> (raw)
In-Reply-To: <20061216143221.47c5e7f3@localhost.localdomain>
Alan wrote:
> The UDMA66 VIA hardware has no controller side cable detect bits we can
> use. This patch minimally fixes the problem by reporting unknown in this
> case and using drive side detection.
>
> The old drivers/ide code does some additional tricks but those aren't
> appropriate now we are in -rc.
>
> Without this update UDMA66 via controllers run slowly. They don't fail so
> it's a borderline call whether this is -rc material or not.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
I think it's #upstream-fixes material (-rc material), and applied as such.
Especially considering that libata pata_* drivers are not the primary
drivers, I think it's best to forward this type of stuff, especially as
it is indeed IMO a fix worth having.
next prev parent reply other threads:[~2006-12-16 16:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-16 14:32 [PATCH] pata_via: Cable detect error Alan
2006-12-16 15:47 ` Jeff Garzik [this message]
2006-12-16 16:16 ` Dave Jones
2006-12-16 16:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45841525.7040406@pobox.com \
--to=jgarzik@pobox.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).