Re: [PATCH 0/4] New firewire stack - updated patches

[Pieter Palmers <pieterp@joow.be>]

Kristian Høgsberg wrote:
> Hi,
> 
> Here's a new set of patches for the new firewire stack.  The changes
> since the last set of patches address the issues that were raised on
> the list and can be reviewed in detail here:
.. for some reason I didn't get patch 3/4 and 4/4 on the linux1394-devel 
list, so I'll reply to this one.

I would suggest a reordering of the interrupt flag checks. Currently the 
interrupts that are least likely to occur are checked first. I don't see 
why. I would reorder the check such that ISO interrupts are checked 
first, as they have the most stringent timing constraints and are most 
likely to occur (when using ISO traffic).

After processing the ISO interrupts (and maybe the Async ones), a bypass 
could be inserted to exit the interrupt handler when there are no other 
interrupts to be handled. All other interrupts are to report relatively 
rare events or errors (error handling still to be added I assume). The 
effective run-length of the interrupt handler would be shorter using 
such a bypass, especially in the case where there is a lot of ISO traffic.

I'm looking forward to your ISO implementation, and I hope to 
incorporate it into FreeBob really fast.

Pieter