From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754839AbWL1NOt (ORCPT ); Thu, 28 Dec 2006 08:14:49 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754840AbWL1NOt (ORCPT ); Thu, 28 Dec 2006 08:14:49 -0500 Received: from il.qumranet.com ([62.219.232.206]:55693 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754839AbWL1NOs (ORCPT ); Thu, 28 Dec 2006 08:14:48 -0500 Message-ID: <4593C345.9040306@qumranet.com> Date: Thu, 28 Dec 2006 15:14:45 +0200 From: Avi Kivity User-Agent: Thunderbird 1.5.0.8 (X11/20061107) MIME-Version: 1.0 To: Ingo Molnar CC: kvm-devel , linux-kernel , Andrew Morton , Linus Torvalds Subject: Re: [patch, try#2] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() References: <45939755.7010603@qumranet.com> <20061228124224.GA28573@elte.hu> <4593BEE6.30206@qumranet.com> <20061228125544.GA31207@elte.hu> <20061228130833.GA555@elte.hu> In-Reply-To: <20061228130833.GA555@elte.hu> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar wrote: > Subject: [patch] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() > From: Ingo Molnar > > fix an GFP_KERNEL allocation in atomic section: > kvm_dev_ioctl_create_vcpu() called kvm_mmu_init(), which calls > alloc_pages(), while holding the vcpu. > > The fix is to set up the MMU state in two phases: kvm_mmu_create() and > kvm_mmu_setup(). > > (NOTE: free_vcpus does an kvm_mmu_destroy() call so there's no need > for any extra teardown branch on allocation/init failure here.) > > Signed-off-by: Ingo Molnar > Applied, thanks. -- error compiling committee.c: too many arguments to function