From: Douglas Gilbert <dougg@torque.net>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Sumant Patro <sumantp@lsil.com>,
James.Bottomley@SteelEye.com, akpm@osdl.org,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
neela.kolli@lsi.com, bo.yang@lsi.com, sumant.patro@lsi.com
Subject: Re: [Patch] scsi: megaraid_{mm,mbox}: init fix for kdump
Date: Sat, 30 Dec 2006 09:31:38 -0500 [thread overview]
Message-ID: <4596784A.1060001@torque.net> (raw)
In-Reply-To: <20061229133741.441a5933.rdunlap@xenotime.net>
Randy Dunlap wrote:
> On Fri, 29 Dec 2006 08:02:17 -0800 Sumant Patro wrote:
>
> See Documentation/SubmittingPatches:
> Please include output of "diffstat -p1 -w70" so that we can easily see
> the scope of the changes.
>
> and see Documentation/CodingStyle for comments below:
>
>
>> diff -uprN linux-2.6.orig/drivers/scsi/megaraid/megaraid_mbox.c linux-2.6.new/drivers/scsi/megaraid/megaraid_mbox.c
>> --- linux-2.6.orig/drivers/scsi/megaraid/megaraid_mbox.c 2006-12-28 09:56:04.000000000 -0800
>> +++ linux-2.6.new/drivers/scsi/megaraid/megaraid_mbox.c 2006-12-29 05:31:48.000000000 -0800
>> @@ -779,6 +780,22 @@ megaraid_init_mbox(adapter_t *adapter)
>> goto out_release_regions;
>> }
>>
>> + // initialize the mutual exclusion lock for the mailbox
>> + spin_lock_init(&raid_dev->mailbox_lock);
>
> Linux uses /*...*/ C89-style comments, not // C99 comments.
Randy
It is about time this absurd stipulation was dropped.
Are there any C compilers that can compile the linux
kernel and that don't accept both _standard_ comment styles?
Doug Gilbert
next prev parent reply other threads:[~2006-12-30 14:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-29 16:02 [Patch] scsi: megaraid_{mm,mbox}: init fix for kdump Sumant Patro
2006-12-29 21:37 ` Randy Dunlap
2006-12-30 14:31 ` Douglas Gilbert [this message]
2006-12-30 15:38 ` Randy Dunlap
-- strict thread matches above, loose matches on Subject: below --
2007-01-03 2:37 Patro, Sumant
2007-01-05 15:10 [PATCH] scsi: megaraid_{mm,mbox} " Sumant Patro
2007-01-05 21:34 ` Randy Dunlap
2007-01-31 17:49 ` Matthias Urlichs
2007-01-05 23:47 Patro, Sumant
2007-01-05 23:50 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4596784A.1060001@torque.net \
--to=dougg@torque.net \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=bo.yang@lsi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=neela.kolli@lsi.com \
--cc=rdunlap@xenotime.net \
--cc=sumant.patro@lsi.com \
--cc=sumantp@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox