From: Avi Kivity <avi@qumranet.com>
To: Ingo Oeser <ioe-lkml@rameria.de>
Cc: kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org,
akpm@osdl.org, mingo@elte.hu
Subject: Re: [PATCH 4/8] KVM: Implement a few system configuration msrs
Date: Mon, 01 Jan 2007 10:20:53 +0200 [thread overview]
Message-ID: <4598C465.5070308@qumranet.com> (raw)
In-Reply-To: <200701010107.18008.ioe-lkml@rameria.de>
Ingo Oeser wrote:
> Hi,
>
> On Thursday, 28. December 2006 11:11, Avi Kivity wrote:
>
>> Index: linux-2.6/drivers/kvm/svm.c
>> ===================================================================
>> --- linux-2.6.orig/drivers/kvm/svm.c
>> +++ linux-2.6/drivers/kvm/svm.c
>> @@ -1068,6 +1068,9 @@ static int emulate_on_interception(struc
>> static int svm_get_msr(struct kvm_vcpu *vcpu, unsigned ecx, u64 *data)
>> {
>> switch (ecx) {
>> + case 0xc0010010: /* SYSCFG */
>> + case 0xc0010015: /* HWCR */
>> + case MSR_IA32_PLATFORM_ID:
>> case MSR_IA32_P5_MC_ADDR:
>> case MSR_IA32_P5_MC_TYPE:
>> case MSR_IA32_MC0_CTL:
>>
>
> What about just defining constants for these?
> Then you can rip out these comments.
>
> Same for linux-2.6/drivers/kvm/vmx.c
>
Yes, there are a few more of these as well. I'll clean them up once
things quiet down a bit.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2007-01-01 8:20 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-28 10:07 [PATCH 0/8] KVM updates for 2.6.20-rc2 Avi Kivity
2006-12-28 10:08 ` [PATCH 1/8] KVM: Use boot_cpu_data instead of current_cpu_data Avi Kivity
2006-12-28 10:09 ` [PATCH 2/8] KVM: Simplify is_long_mode() Avi Kivity
2006-12-28 10:11 ` [PATCH 4/8] KVM: Implement a few system configuration msrs Avi Kivity
2007-01-01 0:07 ` Ingo Oeser
2007-01-01 8:20 ` Avi Kivity [this message]
2006-12-28 10:12 ` [PATCH 5/8] KVM: Move common msr handling to arch independent code Avi Kivity
2006-12-28 10:13 ` [PATCH 6/8] KVM: More msr misery Avi Kivity
2006-12-28 10:14 ` [PATCH 7/8] KVM: Rename some msrs Avi Kivity
2006-12-28 10:15 ` [PATCH 8/8] KVM: Fix oops on oom Avi Kivity
2006-12-28 12:42 ` [patch] kvm: fix GFP_KERNEL allocation in atomic section in kvm_dev_ioctl_create_vcpu() Ingo Molnar
2006-12-28 12:56 ` Avi Kivity
2006-12-28 12:55 ` Ingo Molnar
2006-12-28 13:08 ` [patch, try#2] " Ingo Molnar
2006-12-28 13:14 ` Avi Kivity
2006-12-28 13:23 ` Ingo Molnar
2006-12-28 13:30 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4598C465.5070308@qumranet.com \
--to=avi@qumranet.com \
--cc=akpm@osdl.org \
--cc=ioe-lkml@rameria.de \
--cc=kvm-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox