Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

Alan
2007-01-02T22:38:13Z

On Tue, 02 Jan 2007 16:32:01 -0500
Jeff Garzik <jeff@garzik.org> wrote:

> Jeff Garzik wrote:
> > * After your patch, the code explicitly calls pci_request_region() for
> > BARs 0-4, but never for BAR5.
>
> Without checking for failures, I might add.

The old code didn't reserve 1 or 3 at all let alone check them!

> I agree this is one way to avoid conflicts! ;-)

I did actually go through and verify that there are no drivers where this
would cause a problem including reading some of the painful crap in
drivers/ide to double check.

Is it perfection - no, does it fix 2.6.20 - yes, is it causing any
problems for a 2.6.21 roadmap - no.

Alan