Re: [PATCH] libata: fix combined mode (was Re: Happy New Year (and v2.6.20-rc3 released))

Jeff Garzik
2007-01-03T01:02:42Z

Alan wrote:
> Once combined mode is fixed not to abuse resources (and it originally
> did it that way for a good reason I grant and am not criticising that) the
> entire management for legacy mode, mixed mode and native mode resources
> for an ATA device (including 0x170, 0x3F6 and other wacky magic) becomes
>
> if (pci_request_regions(pdev, "libata")) ...

> Make sense ?

Yes. For 2.6.21. As I've always said.

But for 2.6.20, we are only HALFWAY there, and all these /new/ bugs
exist as a result.

Your patch makes far more sense for 2.6.21, where the "halfway to
salvation" state, and associated rough edges, is not exposed to users.

Fixing the resource tree was only half the solution, since the drivers
that /use/ the resource tree now need updating.

Jeff