From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964891AbXADPAG (ORCPT ); Thu, 4 Jan 2007 10:00:06 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964884AbXADPAG (ORCPT ); Thu, 4 Jan 2007 10:00:06 -0500 Received: from sophia.inria.fr ([138.96.64.20]:55638 "EHLO sophia.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964891AbXADPAF (ORCPT ); Thu, 4 Jan 2007 10:00:05 -0500 Message-ID: <459CFF7B.3070304@yahoo.fr> Date: Thu, 04 Jan 2007 14:22:03 +0100 From: Guillaume Chazarain User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: Andrew Morton CC: Linux Kernel Mailing List Subject: Re: [PATCH 2/2] Handle error in sync_sb_inodes() References: <45958E4F.5080105@yahoo.fr> <20070102132645.264d2b89.akpm@osdl.org> <459C2E6D.2040406@yahoo.fr> <20070103145655.c6e0963d.akpm@osdl.org> In-Reply-To: <20070103145655.c6e0963d.akpm@osdl.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2 (sophia.inria.fr [138.96.64.20]); Thu, 04 Jan 2007 14:22:04 +0100 (MET) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Andrew Morton a écrit : > There's a lot of sloppiness in there. Do these two patches fix things up? > Still no luck :-( It seems you made it possible for sync() to be aware of the returned value, but there's nothing it can do with it since it's 'void sync()'. Then msync() comes after and sees nothing in the mapping flags. Cheers. -- Guillaume