Re: [PATCH 2.6.19] mmc: Add support for SDHC cards (Take 4)

[Pierre Ossman <drzeus-list@drzeus.cx>]

Philip Langdale wrote:
> In the process of developing this patch, we realised that the R6 response definition
> was incorrect and that it should have been identical to R1 (and so should R7).
> Correcting this mistake revealed problems in a couple of host controller drivers that
> relied on the response definitions to be unique. As we need a story for R7, I've
> also fixed up the R6 handling in the affected drivers but I have no idea if it will
> work in practice as I lack the hardware.
>
>   

Do this fix in a separate patch. And cc the relevant maintainers.

> --- /usr/src/linux/drivers/mmc/imxmmc.c	2007-01-01 07:12:02.000000000 -0800
> +++ linux-2.6.19-sdhc/drivers/mmc/imxmmc.c	2007-01-04 05:50:41.000000000 -0800
> @@ -351,9 +360,6 @@
>  	case MMC_RSP_R3: /* short */
>  		cmdat |= CMD_DAT_CONT_RESPONSE_FORMAT_R3;
>  		break;
> -	case MMC_RSP_R6: /* short CRC */
> -		cmdat |= CMD_DAT_CONT_RESPONSE_FORMAT_R6;
> -		break;
>  	default:
>  		break;
>  	}
>   

I think this chunk suffices. Until proven otherwise, regard R6 and R7 as
information the hw does not need to know about. Same thing in tifm_sd.

Rgds

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org