From: Bauke Jan Douma <bjdouma@xs4all.nl>
To: Roman Zippel <zippel@linux-m68k.org>
Cc: "Cyrill V. Gorcunov" <gorcunov@gmail.com>,
kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] qconf: fix SIGSEGV on empty menu items
Date: Sat, 06 Jan 2007 12:46:45 +0100 [thread overview]
Message-ID: <459F8C25.3090102@xs4all.nl> (raw)
In-Reply-To: <Pine.LNX.4.64.0701060415130.12512@localhost.localdomain>
Roman Zippel wrote on 06-01-07 04:20:
<snip>
> Thanks, but this is more complex than necessary.
> It simply lacks some initializers.
<snip>
> ---
> Index: linux-2.6/scripts/kconfig/qconf.cc
> ===================================================================
> --- linux-2.6.orig/scripts/kconfig/qconf.cc 2007-01-05 01:47:54.000000000 +0100
> +++ linux-2.6/scripts/kconfig/qconf.cc 2007-01-05 01:56:54.000000000 +0100
> @@ -915,7 +915,7 @@ void ConfigView::updateListAll(void)
> }
>
> ConfigInfoView::ConfigInfoView(QWidget* parent, const char *name)
> - : Parent(parent, name), menu(0)
> + : Parent(parent, name), menu(0), sym(0)
> {
> if (name) {
> configSettings->beginGroup(name);
> @@ -951,6 +951,7 @@ void ConfigInfoView::setInfo(struct menu
> if (menu == m)
> return;
> menu = m;
> + sym = NULL;
> if (!menu)
> clear();
> else
> -
I can confirm that this patch squashed the segfault.
bjd
prev parent reply other threads:[~2007-01-06 11:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-04 18:06 [PATCH] qconf: fix SIGSEGV on empty menu items Cyrill V. Gorcunov
2007-01-06 3:20 ` Roman Zippel
2007-01-06 11:46 ` Bauke Jan Douma [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459F8C25.3090102@xs4all.nl \
--to=bjdouma@xs4all.nl \
--cc=akpm@osdl.org \
--cc=gorcunov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox