From: Pierre Ossman <drzeus-list@drzeus.cx>
To: Anderson Briglia <anderson.briglia@indt.org.br>
Cc: Russell King <rmk+lkml@arm.linux.org.uk>,
"Lizardo Anderson (EXT-INdT/Manaus)"
<anderson.lizardo@indt.org.br>,
linux-kernel@vger.kernel.org,
"Aguiar Carlos (EXT-INdT/Manaus)" <carlos.aguiar@indt.org.br>,
Tony Lindgren <tony@atomide.com>,
ext David Brownell <david-b@pacbell.net>
Subject: Re: [PATCH 4/4] Add MMC Password Protection (lock/unlock) support V9: mmc_sysfs.diff
Date: Sat, 06 Jan 2007 23:24:50 +0100 [thread overview]
Message-ID: <45A021B2.4090104@drzeus.cx> (raw)
In-Reply-To: <459B9C4E.3020406@indt.org.br>
I've queued it up for -mm, but there a few more comments I want resolved
before this can move to Linus...
You need to clean up mmc_lockable_store(). It had a few broken variable
declarations that even prevented it from compiling, and after I fixed
that I still get:
drivers/mmc/mmc_sysfs.c: In function ‘mmc_lockable_store’:
drivers/mmc/mmc_sysfs.c:160: warning: ignoring return value of
‘device_attach’, declared with attribute warn_unused_result
drivers/mmc/mmc_sysfs.c:93: warning: ‘mmc_key’ may be used uninitialized
in this function
There's also no handling for an invalid string written to the sysfs node.
And third, you're a bit excessive on the goto:s. E.g. out_unlocked is
used in a single place, so it is completely unnecessary. Please do a
general cleanup of the control flow.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2007-01-06 22:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 18:57 [PATCH 4/4] Add MMC Password Protection (lock/unlock) support V9: mmc_sysfs.diff Anderson Briglia
2007-01-03 12:06 ` Anderson Briglia
2007-01-06 13:35 ` Pierre Ossman
2007-01-06 22:24 ` Pierre Ossman [this message]
2007-01-10 13:40 ` Anderson Briglia
2007-01-10 19:25 ` Pierre Ossman
2007-01-29 18:35 ` Anderson Briglia
2007-01-30 18:10 ` Pierre Ossman
2007-01-30 21:26 ` Anderson Briglia
2007-02-03 14:45 ` Pierre Ossman
2007-02-05 21:33 ` Anderson Briglia
2007-02-06 11:55 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45A021B2.4090104@drzeus.cx \
--to=drzeus-list@drzeus.cx \
--cc=anderson.briglia@indt.org.br \
--cc=anderson.lizardo@indt.org.br \
--cc=carlos.aguiar@indt.org.br \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox