public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Soeren Sonnenburg <kernel@nn7.de>
Cc: Jeff Garzik <jeff@garzik.org>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: SATA hotplug from the user side ?
Date: Mon, 15 Jan 2007 11:21:31 +0900	[thread overview]
Message-ID: <45AAE52B.2070705@gmail.com> (raw)
In-Reply-To: <1168672966.3707.24.camel@localhost>

Soeren Sonnenburg wrote:
> Jeff & Tejun thanks *a lot* for clarifying this. I am quite happy to see
> that this is working very reliably!

You're welcome.  :-)

>>> These messages sound eval - so now the question is should I care ?
>>> ( On the other hand it did not crash the machine )
>> So, no, you don't really have to care.  Just make sure the device is
>> unmounted prior to unplugging.
> 
> OK, but then this really should be in the SATA hotplug FAQ (or can one
> fix this somehow?)... No user will ignore messages like this. What is

Yeah, probably.  Care to submit patch to FAQ to Jeff?

> especially annoying is that udev on the first remove/insert cycle
> created a new device node so the disk became /dev/sde (was /dev/sdd):
> dmesg output of reinserting the disk 2 times follows:

That's because something is still holding onto /dev/sdd.  The device
remains dangled until all references to it are gone.  /dev/sdd is still
lingering when the drive is hotplugged; thus, it gets assigned the next
device.

I think this is best solved by udev.  Think of /dev/sdX as kernel
internal name which may change from time to time.  Mount devices with
LABEL's and use udev-provided persistent names to access removable
devices.  Also, libata can be improved to tell udev that certain ports
are external, I think.

Thanks.

-- 
tejun

  reply	other threads:[~2007-01-15  2:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-12  7:57 SATA hotplug from the user side ? Soeren Sonnenburg
2007-01-12 17:04 ` Jeff Garzik
2007-01-12 22:07   ` Soeren Sonnenburg
2007-01-13  1:55     ` Tejun Heo
2007-01-13  7:22       ` Soeren Sonnenburg
2007-01-15  2:21         ` Tejun Heo [this message]
2007-01-22  9:04           ` Soeren Sonnenburg
2007-01-22 21:03             ` Henrique de Moraes Holschuh
2007-01-23  6:23               ` Tejun Heo
2007-01-23 13:10                 ` Henrique de Moraes Holschuh
2007-01-24  2:07                   ` Tejun Heo
2007-01-24  9:09                     ` Soeren Sonnenburg
2007-01-24 15:37                       ` Henrique de Moraes Holschuh
2007-01-25 12:56                         ` Soeren Sonnenburg
2007-01-25 21:56                           ` Henrique de Moraes Holschuh
2007-01-25 21:21                         ` Eric D. Mudama
2007-02-05 11:56                           ` Tejun Heo
2007-02-05 11:50                         ` Tejun Heo
2007-01-23  6:19             ` Tejun Heo
     [not found] <fa.pn1gmGiSlhDVMiPyzEEm1A66vcY@ifi.uio.no>
     [not found] ` <fa.Od11QHN89ZQ9VkFktF6HvxWuLV0@ifi.uio.no>
     [not found]   ` <fa.vsuV8EVipw4cXaHgzWpaf0q1pAA@ifi.uio.no>
     [not found]     ` <fa.8a1kVu4a2ISeaFZcL3migbjZ5N0@ifi.uio.no>
     [not found]       ` <fa.79JzgEcD2u5B9SYqrw3sr5b+iy8@ifi.uio.no>
     [not found]         ` <fa.DH50RMz6OHKG0AoGA/cChsCW8Ig@ifi.uio.no>
2007-01-25  0:33           ` Robert Hancock

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45AAE52B.2070705@gmail.com \
    --to=htejun@gmail.com \
    --cc=jeff@garzik.org \
    --cc=kernel@nn7.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox