Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

Alexey Dobriyan
2007-03-14T10:48:32Z

On 3/14/07, Ingo Molnar <mingo@elte.hu> wrote:
> #define PROCNAME_PML "sys/kernel/preempt_max_latency"
>
> static __init int latency_fs_init(void)
> {
> struct proc_dir_entry *entry;
>
> if (!(entry = create_proc_entry(PROCNAME_PML, 0644, NULL)))
> printk("latency_fs_init(): can't create %s\n",
> PROCNAME_PML);
>
> with your change that broke because beyond /proc/sys/ there are no real
> proc entries anymore, there's no de->subdir directory for
> xlate_proc_name() to find. While the latency tracer isnt upstream, this
> change in semantics does not seem to be intended (the changelog is
> certainly silent about it).

Use register_sysctl_table() for sysctls.