Re: [PATCH 58/59] sysctl: Reimplement the sysctl proc support

Ingo Molnar
2007-03-14T13:48:03Z

* Eric W. Biederman <ebiederm@xmission.com> wrote:

> However it has always been a bug for anything under /proc/sys to not
> be a sysctl. It's not subtle breakage but subtle enforcement of the
> existing rules.

it wasnt really a bug but an uncleanliness - but yeah. The way i used it
is pretty much equivalent to a CTL_UNNUMBERED entry.

> [...] It may be worth adding a test to create_proc_entry that says
> "you silly person you need to use sysctls to create an entry under
> /proc/sys"

yep, agreed - without the "silly person" bit ;-) It was a whole lot
simpler in code to just add in a simple proc entry than a full sysctl
table that i used for nothing. (because the sysctl wasnt really
syscall-settable)

Ingo