Re: [PATCH]: MTRR: fix 32-bit ioctls on x64_32

H. Peter Anvin
2007-01-17T03:52:38Z

Mikael Pettersson wrote:
>
> These #ifdefs are too ugly.
>
> Since you apparently just add aliases for the case labels,
> and do no actual code changes, why not
> 1. make the new cases unconditional, or
> 2. invoke a translation function before the switch which
> maps the MTRRCIOC32_ constants to what the kernel uses
>

Adding a case can add substantially to the generated code, especially if
it makes a compact set of case labels non-compact.

-hpa