From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: linux-mips@linux-mips.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MMC: au1xmmc R6 response support
Date: Thu, 25 Jan 2007 09:31:20 +0100 [thread overview]
Message-ID: <45B86AD8.8050802@drzeus.cx> (raw)
In-Reply-To: <20070125081944.GA8358@roarinelk.homelinux.net>
Manuel Lauss wrote:
>
> Actually, the bug is that because of MMC_RSP_R6 not being handled in
> the switch in au1xmmc_send_command(), the controller gets told that
> no response is expected. I changed the R6 to R1 in mmc.h, thats why
> it worked in the demoboard, and it also works now on the previously
> thought-to-be-broken HW.
>
So in order to detect any similar problems in the future, I'd like a
patch that adds a "default:" to that switch statement.
Rgds
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
PulseAudio, core developer http://pulseaudio.org
rdesktop, core developer http://www.rdesktop.org
next prev parent reply other threads:[~2007-01-25 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 10:08 [PATCH] MMC: au1xmmc R6 response support Manuel Lauss
2007-01-23 18:56 ` Pierre Ossman
2007-01-24 5:52 ` Manuel Lauss
2007-01-24 6:24 ` Manuel Lauss
2007-01-24 10:04 ` Pierre Ossman
2007-01-25 7:20 ` Manuel Lauss
2007-01-25 8:19 ` Manuel Lauss
2007-01-25 8:31 ` Pierre Ossman [this message]
2007-01-25 8:33 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B86AD8.8050802@drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox