From: Pierre Ossman <drzeus@drzeus.cx>
To: "Christopher \"Monty\" Montgomery" <xiphmont@gmail.com>
Cc: perex@suse.cz, greg@kroah.com, mclasen@redhat.com,
jrb@redhat.com, Lennart Poettering <lennart@poettering.net>,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
fedora-desktop-list@redhat.com
Subject: Re: [PATCH] alsa: correct nonsensical sysfs device symlinks
Date: Thu, 25 Jan 2007 12:27:43 +0100 [thread overview]
Message-ID: <45B8942F.7050006@drzeus.cx> (raw)
In-Reply-To: <806dafc20701241750t53b86babn36831cadc7dfa76c@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
Christopher "Monty" Montgomery wrote:
> This patch was generated against 2.6.20-rc5; it fixes a bug that
> cropped up in a late 2.6.19-mm kernel.
>
> When ALSA's sysfs device creation was converted from using
> class_device_create() to device_create(), the fourth param from
> class_device_create() [dev] was simply plugged into arg 2 of
> device_create(). This causes the device symlinks under all the
> class/sound/[node] to point to nonsensical places. Among other
> problems, this breaks HAL and all audio software that depends on HAL.
>
There are no device symlinks anymore, so the current behaviour seems
correct. HAL should follow the symlink, then move up in the device tree
to find a suitable parent.
Rgds
Pierre
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 251 bytes --]
prev parent reply other threads:[~2007-01-25 11:27 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 1:50 [PATCH] alsa: correct nonsensical sysfs device symlinks Christopher "Monty" Montgomery
2007-01-25 4:26 ` Greg KH
2007-01-25 14:11 ` Christopher "Monty" Montgomery
2007-01-25 15:15 ` Pierre Ossman
2007-01-25 15:36 ` Christopher "Monty" Montgomery
2007-01-25 15:40 ` Pierre Ossman
2007-01-25 15:57 ` Christopher "Monty" Montgomery
2007-01-25 16:54 ` [Alsa-devel] " Takashi Iwai
2007-01-25 17:03 ` Christopher "Monty" Montgomery
2007-01-25 17:30 ` xiphmont
2007-01-25 17:47 ` Takashi Iwai
2007-01-25 18:07 ` xiphmont
2007-01-25 18:23 ` Takashi Iwai
2007-01-25 18:34 ` xiphmont
2007-01-25 18:38 ` Takashi Iwai
2007-01-25 18:51 ` xiphmont
2007-01-25 19:49 ` Greg KH
2007-01-25 20:40 ` xiphmont
2007-01-25 21:59 ` Greg KH
2007-01-26 10:53 ` xiphmont
2007-01-26 11:40 ` Takashi Iwai
2007-01-26 18:04 ` Greg KH
2007-01-26 18:25 ` Takashi Iwai
2007-01-26 18:31 ` xiphmont
2007-01-26 19:06 ` Greg KH
2007-01-26 21:58 ` xiphmont
2007-01-26 18:03 ` xiphmont
2007-01-26 18:42 ` Greg KH
2007-01-25 17:48 ` Christopher "Monty" Montgomery
2007-01-25 11:27 ` Pierre Ossman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B8942F.7050006@drzeus.cx \
--to=drzeus@drzeus.cx \
--cc=alsa-devel@alsa-project.org \
--cc=fedora-desktop-list@redhat.com \
--cc=greg@kroah.com \
--cc=jrb@redhat.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mclasen@redhat.com \
--cc=perex@suse.cz \
--cc=xiphmont@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox