RE: [patch] scsi: use lock per host instead of per device for shared queue tag host

Ed Lin
2007-01-24T23:32:53Z

> -----Original Message-----
> From: Michael Reed [mailto:mdr@sgi.com]
> Sent: Wednesday, January 24, 2007 7:59 AM
> To: Ed Lin
> Cc: linux-scsi; linux-kernel; james.Bottomley; jeff; Promise_Linux
> Subject: Re: [patch] scsi: use lock per host instead of per
> device for shared queue tag host
>
>
> How 'bout a comment in scsh_host.h indicating that the
> pointer will be NULL unless
> initialized by the driver?
>
> "Protect shared block queue tag" is unique to stex. Perhaps
> have no comment on
> the variable declaration in scsi_host.h and explain why you
> use it in stex.
>
> Mike
>
>

Thanks for commenting. I agree more detailed explaination should
be better.

It seems another driver(qla4xxx) is also using shared queue tag.
It is natural to imagine there might be same symptom in that
driver. But I don't know the driver and have no hardware so I
can not say anything certain about it.

Ed Lin