Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)

David Miller
2007-01-28T23:53:51Z

From: Adrian Bunk <bunk@stusta.de>
Date: Sun, 28 Jan 2007 23:21:37 +0100

> On Sun, Jan 28, 2007 at 11:41:48AM -0800, Randy Dunlap wrote:
> >...
> > net/built-in.o: In function `q931_help':
> > nf_conntrack_h323_main.c:(.text.q931_help+0x6ad): undefined reference to `ip6_route_output'
> > nf_conntrack_h323_main.c:(.text.q931_help+0x6c3): undefined reference to `ip6_route_output'
> >...
>
> You didn't send your .config, but it seems you had CONFIG_IPV6=m and
> CONFIG_NF_CONNTRACK_H323=y.
>
> In this case, the untested patch below should fix it.
>
> > ~Randy
>
> cu
> Adrian
>
>
> <-- snip -->
>
>
> CONFIG_IPV6=m, CONFIG_NF_CONNTRACK_H323=y results in a compile error.
>
> Fix this by letting NF_CONNTRACK_H323 depend on (IPV6 || IPV6=n).
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Adrian is this the correct way to constrain the selection between
"n" and "m" in this kind of situation? I thought doing something
like "depends on IPV6" is sufficient to achieve that?