From: Patrick McHardy <kaber@trash.net>
To: Adrian Bunk <bunk@stusta.de>
Cc: David Miller <davem@davemloft.net>,
randy.dunlap@oracle.com, akpm@osdl.org,
linux-kernel@vger.kernel.org, netfilter@lists.netfilter.org,
netdev@vger.kernel.org
Subject: Re: [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n)
Date: Tue, 30 Jan 2007 18:13:48 +0100 [thread overview]
Message-ID: <45BF7CCC.9080306@trash.net> (raw)
In-Reply-To: <20070129002108.GC6017@stusta.de>
Adrian Bunk wrote:
> On Sun, Jan 28, 2007 at 04:04:42PM -0800, David Miller wrote:
>
>>From: Adrian Bunk <bunk@stusta.de>
>>Date: Mon, 29 Jan 2007 01:00:11 +0100
>>
>>>"depends on IPV6" would fix the bug - but it would also make
>>>NF_CONNTRACK_H323 unavailable for all people without IPV6 support in
>>>their kernel.
>>
>>Yes, that is an issue.
>>
>>I guess with some slightly ugly ifdefs we could support the
>>whole matrix of possibilities. But perhaps that's undesirable
>>for another reason.
>>...
>
>
> This depends on what NF_CONNTRACK_H323=y, IPV6=m is supposed to be:
> - not allowed (NF_CONNTRACK_H323 must be modular) or
> - NF_CONNTRACK_H323 can only be used for IPV4
>
> My patch implements the first case.
Unfortunately a few ifdefs aren't enough to support IPV6=m,
NF_CONNTRACK_H323=y. For now I think Adrian's patch is the
best solution (IPV6=m isn't that useful anyway since it will
normally get loaded automatically when the first program
attempts to open an AF_INET6 socket and can't be unloaded),
but I'll look into moving the route lookup to the netfilter
AF ops in 2.6.21 so we can also support that configuration.
Acked-by: Patrick McHardy <kaber@trash.net>
next prev parent reply other threads:[~2007-01-30 17:13 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 7:49 2.6.20-rc6-mm1 Andrew Morton
2007-01-28 10:08 ` Unable to select IPV6 [Was: 2.6.20-rc6-mm1] Jiri Slaby
2007-01-28 16:19 ` [-mm patch] fix GFS2 circular dependency Adrian Bunk
2007-01-29 1:55 ` Randy Dunlap
2007-01-29 9:12 ` Steven Whitehouse
2007-01-28 10:25 ` 2.6.20-rc6-mm1 Jiri Slaby
2007-01-30 7:27 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-30 19:30 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-30 20:10 ` 2.6.20-rc6-mm1 Jiri Slaby
2007-01-30 20:22 ` 2.6.20-rc6-mm1 Pierre Ossman
2007-01-30 20:50 ` 2.6.20-rc6-mm1 Anton Altaparmakov
2007-01-28 11:01 ` elevator oops [Was: 2.6.20-rc6-mm1] Jiri Slaby
2007-01-28 17:41 ` Jiri Slaby
2007-02-05 11:54 ` Jens Axboe
2007-01-28 14:59 ` 2.6.20-rc6-mm1: linker error with arch_setup_additional_pages thunder7
2007-01-28 16:56 ` 2.6.20-rc6-mm1 Martin J. Bligh
2007-01-28 23:01 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-28 23:23 ` 2.6.20-rc6-mm1 Martin J. Bligh
2007-01-28 23:38 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-30 2:42 ` 2.6.20-rc6-mm1 Suparna Bhattacharya
2007-01-30 2:42 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-30 3:26 ` 2.6.20-rc6-mm1 Martin Bligh
2007-01-28 17:02 ` 2.6.20-rc6-mm1 Martin J. Bligh
2007-01-28 17:04 ` 2.6.20-rc6-mm1 Martin J. Bligh
2007-01-28 19:04 ` [-mm patch] fix CONFIG_SATA_SIS=y compile error Adrian Bunk
2007-01-28 19:41 ` 2.6.20-rc6-mm1 (build) Randy Dunlap
2007-01-28 22:21 ` [2.6 patch] NF_CONNTRACK_H323 must depend on (IPV6 || IPV6=n) Adrian Bunk
2007-01-28 23:53 ` David Miller
2007-01-29 0:00 ` Adrian Bunk
2007-01-29 0:04 ` David Miller
2007-01-29 0:21 ` Adrian Bunk
2007-01-29 1:22 ` Randy Dunlap
2007-01-30 17:13 ` Patrick McHardy [this message]
2007-01-28 22:31 ` 2.6.20-rc6-mm1 Michal Piotrowski
2007-01-28 23:10 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 5:17 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 5:29 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 6:43 ` 2.6.20-rc6-mm1 Andrew Morton
2007-01-29 7:21 ` 2.6.20-rc6-mm1 Herbert Xu
2007-01-29 8:35 ` 2.6.20-rc6-mm1 Ingo Molnar
2007-01-29 2:50 ` [PATCH -mm] fix DocBook build Don Mullis
2007-01-30 1:11 ` [-mm patch] vmi: cleanups Adrian Bunk
2007-01-30 4:56 ` Zachary Amsden
2007-01-30 1:11 ` [-mm patch] cx88-video.c: remove struct radionorms Adrian Bunk
2007-01-30 1:11 ` [RFC: -mm patch] CONFIG_INPUT_DEBUG improvements Adrian Bunk
2007-01-30 15:07 ` Jiri Kosina
2007-01-30 15:13 ` Adrian Bunk
2007-01-30 1:11 ` [-mm patch] drivers/char/pcmcia/ipwireless_cs_*: possible cleanups Adrian Bunk
2007-01-30 1:12 ` [RFC: -mm patch] #if 0 v4l_printk_ioctl_arg() Adrian Bunk
2007-02-06 22:12 ` [-mm patch] fs/proc/: make code static Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BF7CCC.9080306@trash.net \
--to=kaber@trash.net \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter@lists.netfilter.org \
--cc=randy.dunlap@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox