From: Jay Cliburn <jacliburn@bellsouth.net>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, jeff@garzik.org,
Chris Snook <csnook@redhat.com>
Subject: Re: [PATCH] atl1_main: pci_module_int returns to haunt us
Date: Wed, 31 Jan 2007 16:04:20 -0600 [thread overview]
Message-ID: <45C11264.1080907@bellsouth.net> (raw)
In-Reply-To: <20070131170456.69fe6441@localhost.localdomain>
Alan wrote:
> Perhaps Adrian would care to simply delete the pci_module_init ancient compat
> code so nobody else can inadvertently merge a driver that uses it.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c
> --- linux.vanilla-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 14:20:41.000000000 +0000
> +++ linux-2.6.20-rc6-mm3/drivers/net/atl1/atl1_main.c 2007-01-31 15:25:29.083361224 +0000
> @@ -2482,12 +2482,9 @@
> **/
> static int __init atl1_init_module(void)
> {
> - int ret;
> printk(KERN_INFO "%s - version %s\n", atl1_driver_string, DRIVER_VERSION);
> printk(KERN_INFO "%s\n", atl1_copyright);
> - ret = pci_module_init(&atl1_driver);
> -
> - return ret;
> + return pci_register_driver(&atl1_driver);
> }
>
> module_init(atl1_init_module);
Ack. As expected, works fine. Thanks.
Jay
prev parent reply other threads:[~2007-01-31 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 17:04 [PATCH] atl1_main: pci_module_int returns to haunt us Alan
2007-01-31 22:04 ` Jay Cliburn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C11264.1080907@bellsouth.net \
--to=jacliburn@bellsouth.net \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=csnook@redhat.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox