From: "bibo,mao" <bibo_mao@linux.intel.com>
To: Frederic Riss <frederic.riss@gmail.com>
Cc: Bjorn Helgaas <bjorn.helgaas@hp.com>,
linux-kernel@vger.kernel.org, artiom.myaskouvskey@intel.com,
akpm@osdl.org, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] EFI x86: pass firmware call parameters on the stack
Date: Fri, 02 Feb 2007 09:32:26 +0800 [thread overview]
Message-ID: <45C294AA.9000400@linux.intel.com> (raw)
In-Reply-To: <87d3b2040702010010h7534cc9cte1605e5cecd56025@mail.gmail.com>
Frederic Riss wrote:
> 2007/2/1, bibo,mao <bibo_mao@linux.intel.com>:
>> currently x86_64 kernel does not support efi, efi convention comply to
>> MS convention. On ia32 parameter is passed on stack, on x86_64 parameter
>> is passed by registers but that is different from x86_64 linux
>> convention.
>
> Is an x86_64 EFI firmware required to have 2 entry points, one x86_64
> and one in ia32 mode ? If that's not the case, it means that an i386
> kernel won't be able to work correctly on an EFI powered x86_64 box...
>
AFAIK x86_64 EFI firmware now has only one entry point, i386 kernel
can not boot up with EFI powered x86_64 box.
>> How about adding EFIAPI prefix before efi runtime service function, this
>> prefix has different definition in different architecture.
>
> Have you any objection to the second patch I posted? It's not only a
> matter of passing arguments, ia64 does quite a lot of things in its
> wrapper functions. I can easily imagine that such additional work
> could be added in the i386 wrappers if EFI becomes more widely used.
>
I do not object your second patch if there will be more wrapper functions
to be added in i386 efi code. I have to give up my patch:)
thanks
bibo,mao
prev parent reply other threads:[~2007-02-02 1:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 19:01 [PATCH] EFI x86: pass firmware call parameters on the stack Frédéric Riss
2007-01-30 19:10 ` Andrew Morton
2007-01-30 19:16 ` Frédéric Riss
2007-01-30 19:17 ` Bjorn Helgaas
2007-01-30 20:41 ` Frédéric Riss
2007-02-01 2:32 ` bibo,mao
2007-02-01 8:10 ` Frederic Riss
2007-02-02 1:32 ` bibo,mao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C294AA.9000400@linux.intel.com \
--to=bibo_mao@linux.intel.com \
--cc=akpm@osdl.org \
--cc=artiom.myaskouvskey@intel.com \
--cc=bjorn.helgaas@hp.com \
--cc=frederic.riss@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox