From: Eric Sandeen <sandeen@sandeen.net>
To: linux-kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: How far should BLKROSET/set_device_ro() go?
Date: Mon, 05 Feb 2007 23:03:01 -0600 [thread overview]
Message-ID: <45C80C05.6090807@sandeen.net> (raw)
While looking at another bug a while ago, I noticed that in 2.6 at
least, set_device_ro() sets the policy on the hd_struct to mark it
readonly, but it appears that IO is only really blocked from userspace,
via generic_write_checks().
There are bdev_read_only() checks in other places, but nothing in a
common spot to reject all possible IO.
Should we have something in generic_make_request() to reject ALL IO on a
readonly bdev, or is that further than the policy is supposed to go? Or
is it up to each location that might possibly issue that IO to check it
and be well-behaved?
The motivation for this investigation was ext3 happily doing orphan
inode recovery on read-only lvm snapshot....
Thanks,
-Eric
reply other threads:[~2007-02-06 5:03 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C80C05.6090807@sandeen.net \
--to=sandeen@sandeen.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox