From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Andi Kleen <ak@suse.de>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Christoph Lameter <clameter@sgi.com>,
bob.picco@hp.com
Subject: Re: [RFC] [PATCH] more support for memory-less-node.
Date: Tue, 13 Feb 2007 10:11:15 -0800 [thread overview]
Message-ID: <45D1FF43.9050800@mbligh.org> (raw)
In-Reply-To: <200702131845.05913.ak@suse.de>
Andi Kleen wrote:
>> Your description of the node is correct, it's an arbitrary container of
>> one or more resources. Not only is this definition flexible, it's also
>> very useful, for memory hotplug, odd types of NUMA boxes, etc.
>
> I must disagree here. Special cases are always dangerous especially
> if they are hard to regression test. I made this discovery the hard
> way on x86-64 ... It's best to eliminate them in the first place,
> otherwise they will later come back and bite you when you don't expect it.
>
> Adding NULL tests all over mm for this would seem like a clear case
> of this to me.
I wasn't suggesting having NULL pointers for pgdats, if that's what you
mean. Just nodes with no memory in them, the pgdat would still be there.
pgdat = struct node, except everything's badly named.
next prev parent reply other threads:[~2007-02-13 18:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-13 6:57 [RFC] [PATCH] more support for memory-less-node KAMEZAWA Hiroyuki
2007-02-13 8:29 ` Andi Kleen
2007-02-13 8:38 ` KAMEZAWA Hiroyuki
2007-02-13 17:25 ` Christoph Lameter
2007-02-14 0:12 ` KAMEZAWA Hiroyuki
2007-02-13 17:24 ` Christoph Lameter
2007-02-13 17:09 ` Martin J. Bligh
2007-02-13 17:45 ` Andi Kleen
2007-02-13 18:03 ` Christoph Lameter
2007-02-13 18:16 ` Martin J. Bligh
2007-02-13 18:50 ` Christoph Lameter
2007-02-14 0:20 ` KAMEZAWA Hiroyuki
2007-02-13 18:11 ` Martin J. Bligh [this message]
2007-02-13 18:18 ` Andi Kleen
2007-02-13 18:26 ` Martin J. Bligh
2007-02-13 18:51 ` Bob Picco
[not found] <7NZO0-6et-1@gated-at.bofh.it>
[not found] ` <7Oa6N-5If-3@gated-at.bofh.it>
[not found] ` <7Oaq4-6ow-7@gated-at.bofh.it>
[not found] ` <7Oaq6-6ow-17@gated-at.bofh.it>
2007-02-15 12:21 ` Bodo Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D1FF43.9050800@mbligh.org \
--to=mbligh@mbligh.org \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=bob.picco@hp.com \
--cc=clameter@sgi.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox