Re: [PATCH 0/4] coredump: core dump masking support v2

["Kawai, Hidehiro" <hidehiro.kawai.ez@hitachi.com>]

Hi,

I'm sorry that I couldn't reply you sooner.

Pavel Machek wrote:
>>Okay, I'll adopt your idea in the next version.
>>I'm going to provide the proc entry as follows:
>>
>>  (1) /proc/<pid>/core_flags/flags
>>  (2) /proc/<pid>/core_flags/omit_anon_shared
>>
>>(1) is the same as current core_flags. It is for expert users.
>>(2) corresponds to one bit in (1).
>>If (2) is set to 1, anonymous shared memory of the process is never
>>dumped.
> 
> Now, that's what I call an ugly interface.

I considered for a while, and then I decided not to use the
above-stated interfaces. Instead, I'll create just one proc entry
to access to one core dump flag:
  /proc/<pid>/coredump_omit_anonymous_shared

I think it is simple enough.
Would you think it is still ugly?

 
> Can we simply add ulimit with boolean value, that says dump
> anon_shared... or not? It will be simpler and faster, because you'll
> not need locking.

Yes, using ulimit will be simpler and faster, but less flexible.
The core dump flags can be changed only before running the program.
If the user modifies the program, the user will be able to change the
flags anytime. But the user can't always modify the program.

I need the ability to change the core dump flags anytime.


Thanks,
-- 
Hidehiro Kawai
Hitachi, Ltd., Systems Development Laboratory