Re: [patch 10/21] Xen-paravirt: Name: dont export paravirt_ops structure, do individual functions

Rusty Russell
2007-02-14T05:52:15Z

On Tue, 2007-02-13 at 17:06 -0800, Zachary Amsden wrote:
> Jeremy Fitzhardinge wrote:
> > Wrap the paravirt_ops members we want to export in wrapper functions.
> > Since we binary-patch the critical ones, this doesn't make a speed
> > impact.
>
> This turned out really hideous looking to me. Can't we split the struct
> into GPL'd and non-GPL'd functions instead? We still have the same
> granularity, and none of this function call to an indirect function call
> nonsense.

This patch, indeed, should not have been pushed in this series. But not
for that reason: I actually prefer explicit exports.

KVM and lguest need more symbols, so the real patch will make them use
native_XXX versions explicitly...

Cheers,
Rusty.