Re: [patch 15/21] Xen-paravirt: Add Xen interface header files

Eric W. Biederman
2007-02-14T20:47:41Z

Jeremy Fitzhardinge <jeremy@goop.org> writes:

> Add Xen interface header files. These are taken fairly directly from
> the Xen tree and hence the style is not entirely in accordance with
> Linux guidelines. There is a tension between fitting with Linux coding
> rules and ease of maintenance.
>
> Define macros and inline functions for doing hypercalls into the
> hypervisor.
>
> Signed-off-by: Jeremy Fitzhardinge <jeremy@xensource.com>
> Signed-off-by: Ian Pratt <ian.pratt@xensource.com>
> Signed-off-by: Christian Limpach <Christian.Limpach@cl.cam.ac.uk>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org>
>
>
> --
> include/asm-i386/hypercall.h | 416 +++++++++++++++++++++++++++++
> include/asm-i386/hypervisor.h | 72 +++++

Are hypercall.h and hypervisor.h generic or are they Xen specific.
If they are Xen specific (as it appears) then are inappropriately
named.

> include/xen/interface/arch-x86_32.h | 187 +++++++++++++
Why isn't this file include-asm-i386/xen/arch-x86_32.h ?

> include/xen/interface/elfnote.h | 133 +++++++++
> include/xen/interface/event_channel.h | 195 ++++++++++++++
> include/xen/interface/features.h | 43 +++
> include/xen/interface/grant_table.h | 301 +++++++++++++++++++++
> include/xen/interface/io/blkif.h | 96 ++++++
> include/xen/interface/io/console.h | 23 +
> include/xen/interface/io/netif.h | 152 ++++++++++
> include/xen/interface/io/ring.h | 260 ++++++++++++++++++
> include/xen/interface/io/xenbus.h | 42 +++
> include/xen/interface/io/xs_wire.h | 87 ++++++
> include/xen/interface/memory.h | 145 ++++++++++
> include/xen/interface/physdev.h | 61 ++++
> include/xen/interface/sched.h | 77 +++++
> include/xen/interface/vcpu.h | 109 +++++++
> include/xen/interface/version.h | 60 ++++
> include/xen/interface/xen.h | 445 ++++++++++++++++++++++++++++++++
> 19 files changed, 2904 insertions(+)

Eric