Re: [Xen-devel] Re: [patch 12/21] Xen-paravirt: Allocate and free vmalloc areas

Keir Fraser
2007-02-16T17:12:36Z

On 16/2/07 17:10, "Keir Fraser" <keir@xensource.com> wrote:

> On 16/2/07 16:46, "Jeremy Fitzhardinge" <jeremy@goop.org> wrote:
>
>> Yes, that would work. Unfortunately that's i386 arch-specific, whereas
>> the rest of this code is generic. I guess I could just move it all to
>> arch/i386/mm.
>
> This whole thing isn't an issue on ia64 (they no-op lock_vm_area) and
> powerpc doesn't use any of the Xen driver code at this time.
> vmalloc_sync_all is supported by both i386 and x86_64, so we can make the
> call conditional on CONFIG_X86 so that ia64 will continue to build. This is
> what I've done in xen-unstable.

In fact that file is only built for i386 and x86_64, so there really is no
problem with using vmalloc_sync_all() directly and without ifdef.

-- Keir