Re: [patch 17/24] Xen-paravirt_ops: avoid having a bad selector in %gs during context switch

Keir Fraser
2007-02-21T22:17:15Z

On 21/2/07 22:10, "Andi Kleen" <ak@suse.de> wrote:

>> /*
>> + * Temporary hack: zero gs now that we've saved it so that Xen
>> + * doesn't try to reload the old value after changing the GDT
>> + * during the context switch. This can go away once Xen has
>> + * been taught to only reload %gs when it absolutely must.
>> + */
>> + loadsegment(gs, 0);
>
> Sorry, but i don't really want that unconditionally in the context switch.
> Adding a paravirt ops for it would be also ugly. Can Xen be fixed?

This is not an issue for correctness so this can safely be removed and still
work with current Xen.

-- Keir