Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

Jens Axboe
2007-02-22T11:05:38Z

On Thu, Feb 22 2007, Jeff Garzik wrote:
> Robert Hancock wrote:
> >This patch adds in some NCQ blacklist entries taken from the Silicon
> >Image Windows drivers' .inf files for the 3124 and 3132 controllers.
> >These entries were marked as ""DisableSataQueueing". Assume these are
> >in their blacklist for a reason and disable NCQ on these drives.
> >
> >Signed-off-by: Robert Hancock <hancockr@shaw.ca>
> >
> >--- linux-2.6.21-rc1edit/drivers/ata/libata-core.c.prev 2007-02-21
> >22:23:05.000000000 -0600
> >+++ linux-2.6.21-rc1edit/drivers/ata/libata-core.c 2007-02-21
> >22:25:44.000000000 -0600
> >@@ -3269,6 +3269,13 @@ static const struct ata_blacklist_entry
> > /* Devices with NCQ limits */
> >
> >+ /* The following blacklist entries are taken from the Windows
> >+ driver .inf files for the Silicon Image 3124 and 3132. */
> >+ { "Maxtor 7B250S0", "BANC1B70", ATA_HORKAGE_NONCQ, },
> >+ { "HTS541060G9SA00", "MB3OC60D", ATA_HORKAGE_NONCQ, },
> >+ { "HTS541080G9SA00", "MB4OC60D", ATA_HORKAGE_NONCQ, },
> >+ { "HTS541010G9SA00", "MBZOC60D", ATA_HORKAGE_NONCQ, },
>
> Do we have information that these drives fail on non-SiI controllers?
>
> Sometimes the problem can be related to a single family of controllers.

I don't know about the Hitachi's, but the Maxtor with that firmware is
definitely broken. It _appeared_ to work if the depth was limited to 4,
but I didn't test it long enough to be absolutely certain. So the safest
is indeed to blacklist it.

I'm pretty sure my initial NCQ patches had a blacklist entry for that
drive as well, but apparently the blacklist got lost somewhere along the
way?

--
Jens Axboe