From: Zachary Amsden <zach@vmware.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: linux-kernel@vger.kernel.org, Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [RFC] Use para_fill instead of vmi_get_function for APIC ops
Date: Mon, 26 Feb 2007 17:00:40 -0800 [thread overview]
Message-ID: <45E382B8.8040207@vmware.com> (raw)
In-Reply-To: <45E38032.3020704@codemonkey.ws>
Anthony Liguori wrote:
>
> It would be really great if one could write a ROM by just specifying a
> GetRelocationInfo function that always returns rel.type == NONE.
> Right now, there are a half a dozen or so ops that have to be
> implemented b/c of the vmi_get_function stuff.
Yes, I need to clean this up. There are a couple other places where I
took liberties and just did things that way because this was how our
VMware ROM was implemented. Just be sure, if you are going to implement
a ROM, it has to be GPL'd now, otherwise the VMI code won't accept it.
>
>> I assume this patch is signed-off-by you? If so, I'll add it to my
>> patch queue.
>
> Yeah, but please make sure to test it. I haven't at all.
It passes test level 1, which is good enough to make it into my patchset.
Zach
next prev parent reply other threads:[~2007-02-27 1:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-27 0:06 [RFC] Use para_fill instead of vmi_get_function for APIC ops Anthony Liguori
2007-02-27 0:43 ` Zachary Amsden
2007-02-27 0:49 ` Anthony Liguori
2007-02-27 1:00 ` Zachary Amsden [this message]
2007-02-27 1:36 ` Jeremy Fitzhardinge
2007-02-27 16:17 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E382B8.8040207@vmware.com \
--to=zach@vmware.com \
--cc=anthony@codemonkey.ws \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox