Re: [patch 04/26] Xen-paravirt_ops: Add pagetable accessors to pack and unpack pagetable entries

Ingo Molnar
2007-02-28T08:38:54Z

* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> >> +#ifdef CONFIG_PARAVIRT
> >> +/* After pte_t, etc, have been defined */
> >> +#include <asm/paravirt.h>
> >> +#endif
> >>
> >
> > hm - there's already a CONFIG_PARAVIRT conditional in
> > asm-i386/paravirt.h.
>
> Yes, but it happens after asm/paravirt.h has already included some
> things, and it ends up causing problems. paravirt.h still defines
> various stub functions in the !CONFIG_PARAVIRT case, so it needs to do
> the includes either way.

hm, it then needs to be fixed first, instead of adding to the mess.

Ingo