Re: [patch 09/26] Xen-paravirt_ops: remove HAVE_ARCH_MM_LIFETIME, define no-op architecture implementations

Jeremy Fitzhardinge
2007-02-27T17:56:42Z

James Bottomley wrote:
> On Tue, 2007-02-27 at 09:21 -0800, Jeremy Fitzhardinge wrote:
>
>> You mean add the two stubs to asm-generic/mmu_context.h, and then
>> include that in all these files? That would be cleaner, but it
>> wouldn't
>> remove the need to touch all these files, would it?
>>
>
> it would if you added asm-generic/mmu_context_paravirt.h
>

include/asm-generic isn't in the compile include path; its contents are
only ever used if they're explicitly included by some other asm/
header. I seem to remember there was some debate about this, but I
don't really understand the rationale for the current arrangement; it
makes sense to me to have asm-generic as a set of fallback default includes.

> and only included that in the main kernel files that need the three
> operations (that's just fork.c and mmap.c, isn't it)?
>

Yeah, it's really only two operations. activate_mm happens in arch code
anyway, so there's no need to make a fuss about it.

J